Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next link requirement #166

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Add next link requirement #166

merged 2 commits into from
Nov 8, 2018

Conversation

black-tea
Copy link
Contributor

Addresses part of #165, by adding an explicit requirement to the README that paginated payloads should include a next key at a minimum.

Addresses part of #165, by adding an explicit requirement to the README that paginated payloads should include a `next` key at a minimum.
thekaveman
thekaveman previously approved these changes Nov 7, 2018
Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is an extra space that snuck in on the end of line 42, but no biggie.

@thekaveman thekaveman added this to the 0.2.1 milestone Nov 7, 2018
@thekaveman thekaveman added the Provider Specific to the Provider API label Nov 7, 2018
Following discussion #165, suggestion adds a explicit requirement for the last page of any paginated payload to return a value of `null` for the `next` key.
@hunterowens hunterowens merged commit bdff619 into 0.2.x Nov 8, 2018
@hunterowens hunterowens deleted the black-tea-patch-1 branch November 8, 2018 17:29
hunterowens added a commit that referenced this pull request Dec 4, 2018
* 0.2.1: (61 commits)
  updating release notes for 0.2.x
  fix for required properties in generated schema
  add WIND as a dockless mobility provider (#185)
  add Spin as a dockless mobility provider (#184)
  Reverts PR #146, moving Timestamp change into future release (#180)
  wheels (#177)
  adding info about mailing list. (#175)
  Adding Release guidelines (#147)
  Update providers.csv (#174)
  Add `next` link requirement (#166)
  Add OAauth client_credentials auth guidelines section
  update JUMP provider URL (#164)
  allowing null for links.next (#162)
  Agency vs Provider Clarification. [#148] (#150)
  Add LADOT Guidelines for the Handling of MSP Data (#154)
  allowing for null links properties
  Suggestion: Add Clarification to Propulsion Types
  fix versions
  remove oneOf when required is being added
  regenerate the schemas
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Provider Specific to the Provider API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants