Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-trying interactions. #219

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Avoid re-trying interactions. #219

merged 3 commits into from
Mar 10, 2023

Conversation

balazsracz
Copy link
Collaborator

@balazsracz balazsracz commented Mar 10, 2023

  • Eliminates re-tries from the pip and snip request for the MimicNodeStore. OpenLCB is a guaranteed-delivery protocol, so re-trying is not useful.

Current re-try behavior causes errors when multiple responses arrive.

- Bumps timeout for a SNIP and PIP request from 700 msec to 3000 msec.
- Eliminates re-tries from the pip and snip request for the MimicNodeStore.
  OpenLCB is a guaranteed-delivery protocol, so re-trying is not useful.

Current re-try behavior causes errors when multiple responses arrive.
…orepeat

* 'master' of github.com:openlcb/OpenLCB_Java:
  Address space improvements (#218)
  Config Node displays more info as needed (#217)
  Update default backup filename to id-name-softversion-date-time (#214)
  Automate sizing of NodeSelector JComboBox (#216)
  add EventID.toShortString() (#215)
  Allow NodeSelector user to specify length of ID string (#213)
  Hub - add separate options for sending / receiving line termination characters (#212)
  Hub Line Endings / GC Serial (#208)
We are not sending more than one interaction at a time, and a long deadline
appears to freeze the display.
@balazsracz balazsracz changed the title Update timeouts and avoid re-trying interactions. Avoid re-trying interactions. Mar 10, 2023
@balazsracz balazsracz merged commit e8af556 into master Mar 10, 2023
@balazsracz balazsracz deleted the bracz-norepeat branch March 10, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant