Update default backup filename to id-name-softversion-date-time #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See discussion at https://groups.io/g/layoutcommandcontrol/topic/97184619 |
balazsracz
reviewed
Feb 25, 2023
| public void runRestore() { | ||
| // First select a file to save to. | ||
| fci.setDialogTitle("Open configuration restore file"); | ||
| fci.rescanCurrentDirectory(); | ||
| fci.setSelectedFile(new File("config." + rep.getRemoteNodeAsString() + ".txt")); | ||
|
|
||
| fci.setSelectedFile(new File(generateFileName())); |
There was a problem hiding this comment.
This surely won't work with the date and time now being part of the filename.
Can the file chooser get something like a glob pattern?
There was a problem hiding this comment.
You're right that this won't end up selecting a file. This goes to the saved directory (if any), but doesn't select a file.
Unfortunately, no, there's no glob capability in the JFileChooser. Coding one is possible, but it's a non-trivial amount of work.
Another approach might be to present the last filename used by a Save (in the same session) and select that.
|
On Wed, Mar 1, 2023 at 5:36 AM Bob Jacobsen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/org/openlcb/cdi/swing/CdiPanel.java
<#214 (comment)>:
> public void runRestore() {
// First select a file to save to.
fci.setDialogTitle("Open configuration restore file");
fci.rescanCurrentDirectory();
- fci.setSelectedFile(new File("config." + rep.getRemoteNodeAsString() + ".txt"));
+
+ fci.setSelectedFile(new File(generateFileName()));
You're right that this won't end up selecting a file. This goes to the
saved directory (if any), but doesn't select a file.
Unfortunately, no, there's no glob capability in the JFileChooser. Coding
one is possible, but it's a non-trivial amount of work.
Another approach might be to present the last filename used by a Save (in
the same session) and select that.
This sounds like an ok behavior. If there wasn't anything in the current
session, then just show the directory with *.txt in the chooser.
… Message ID: ***@***.***>
|
|
Thanks. Changes made. |
balazsracz
approved these changes
Mar 1, 2023
balazsracz
added a commit
that referenced
this pull request
Mar 10, 2023
…orepeat * 'master' of github.com:openlcb/OpenLCB_Java: Address space improvements (#218) Config Node displays more info as needed (#217) Update default backup filename to id-name-softversion-date-time (#214) Automate sizing of NodeSelector JComboBox (#216) add EventID.toShortString() (#215) Allow NodeSelector user to specify length of ID string (#213) Hub - add separate options for sending / receiving line termination characters (#212) Hub Line Endings / GC Serial (#208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default filename when doing a backup from the CDI pane. The new form is id-name-softwareversion-date-time, e.g.