Automate sizing of NodeSelector JComboBox #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any code to resize the combo box when there are nodes. The only code seems to be active when node count == 0. |
|
A JComboBox by default has a preferred size that will hold its longest content. That's used by a pack() call during layout, so it'll be that size unless there are external constraints. The previous code was overriding that behavior by always by setting a manual size. I removed that to allow the default behavior to work, setting it specifically only when there isn't any content. That's needed because the default-no-content size is 20 characters, smaller than our typical identifiers. |
balazsracz
added a commit
that referenced
this pull request
Mar 10, 2023
…orepeat * 'master' of github.com:openlcb/OpenLCB_Java: Address space improvements (#218) Config Node displays more info as needed (#217) Update default backup filename to id-name-softversion-date-time (#214) Automate sizing of NodeSelector JComboBox (#216) add EventID.toShortString() (#215) Allow NodeSelector user to specify length of ID string (#213) Hub - add separate options for sending / receiving line termination characters (#212) Hub Line Endings / GC Serial (#208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the handling of the JComboBox in org.openlcb.swing.NodeSelector so that it automatically sizes itself to the largest selection string available when the NodeSelector is created.
If there are no known nodes, a default of 70 spaces wide it used
The JComboBox does not resize if additional nodes are discovered after it's been created to prevent the GUI from moving around spontaneously.