-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type definitions #125
Fix type definitions #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perrinjerome thanks for the help!
According to the specs, there are some new base types:
- WorkDoneProgressCreateParams
- WorkDoneProgressBegin
- WorkDoneProgressReport
- WorkDoneProgressEnd
- WorkDoneProgressCancelParams
- WorkDoneProgressParams
- WorkDoneProgressOptions
- PartialResultParams
So, HoverParams
should extend WorkDoneProgressParams
instead of adding a workDoneToken
field. You do not have to add all of these types in this PR, maybe you can just remove self.workDoneToken = work_done_token
from HoverParams
and we can merge it.
Description (e.g. "Related to ...", etc.)
This commit
ClientInfo
toInitializeParams
HoverParams
TextDocumentItem
fromVersionedTextDocumentIdentifier
__init__
.Code review checklist (for code reviewer to complete)