Mark deprecated rangeLength optional in TextDocumentContentChangeEvent #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danixeee
suggested changes
May 14, 2020
The rangeLength attribute in the TextDocumentContentChangeEvent is marked deprecated and therefore no longer enforced by pygls. If it is passed by a client, it is accepted silently, but as it is not needed for text synchronization at all, it is marked optional. As the result the whole Document.apply_change() method can be slightly simplified.
According to the LSP specs `range` is not optional but may be empty.
danixeee
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rangeLength attribute in the TextDocumentContentChangeEvent is marked deprecated and therefore no longer enforced by pygls. If it is passed by a client, it is accepted silently, but as it is not needed for text synchronization at all, it is marked optional.
As the result the whole Document.apply_change() method can be slightly simplified.
Description (e.g. "Related to ...", etc.)
Please replace this description with a concise description of this Pull Request.
Code review checklist (for code reviewer to complete)