Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In SymbolKindAbstract value_set should be a list type based on the spec. #122

Closed
karthiknadig opened this issue May 9, 2020 · 0 comments · Fixed by #125
Closed

In SymbolKindAbstract value_set should be a list type based on the spec. #122

karthiknadig opened this issue May 9, 2020 · 0 comments · Fixed by #125
Labels
bug Something isn't working

Comments

@karthiknadig
Copy link
Contributor

pygls/pygls/types.py

Lines 1119 to 1121 in 144bbc0

class SymbolKindAbstract:
def __init__(self, value_set: SymbolKind):
self.valueSet = value_set

This should probably be:

def __init__(self, value_set: List[SymbolKind]):

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_symbol

@deathaxe deathaxe mentioned this issue May 17, 2020
8 tasks
@danixeee danixeee added the bug Something isn't working label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants