Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Sports2D: Compute 2D joint and segment angles from your smartphone #6375

Closed
editorialbot opened this issue Feb 19, 2024 · 54 comments
Assignees
Labels
Jupyter Notebook pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 19, 2024

Submitting author: @davidpagnon (David Pagnon)
Repository: https://github.com/davidpagnon/Sports2D
Branch with paper.md (empty if default branch):
Version: 0.3.1
Editor: @Kevin-Mattheus-Moerman
Reviewers: @tuliofalmeida, @nicos1993, @johnjdavisiv
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1d525bbb2695c88c6ebbf2297bd35897"><img src="https://joss.theoj.org/papers/1d525bbb2695c88c6ebbf2297bd35897/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1d525bbb2695c88c6ebbf2297bd35897/status.svg)](https://joss.theoj.org/papers/1d525bbb2695c88c6ebbf2297bd35897)

Author instructions

Thanks for submitting your paper to JOSS @davidpagnon. Currently, there isn't a JOSS editor assigned to your paper.

@davidpagnon if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Feb 19, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.05 s (409.0 files/s, 172583.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                              1              0            931           1911
Python                          11            414            681           1329
Jupyter Notebook                 1              0           2811            296
Markdown                         2            112              0            245
TeX                              1             24              0            239
YAML                             3             17             14             96
TOML                             3             37             33             94
-------------------------------------------------------------------------------
SUM:                            22            604           4470           4210
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1280

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2006.10204 is OK
- 10.1109/TPAMI.2019.2929257 is OK
- 10.2307/2683591 is OK
- 10.1186/s40798-018-0139-y is OK
- 10.1038/s41593-018-0209-y is OK
- 10.1080/24748668.2008.11868456 is OK
- 10.21105/joss.04362 is OK
- 10.1101/2022.07.07.499061 is OK

MISSING DOIs

- 10.1101/2022.09.29.22280368 may be a valid DOI for title: Smartphone videos of the sit-to-stand test predict osteoarthritis and health outcomes in a nationwide study
- 10.1007/s00167-021-06709-2 may be a valid DOI for title: A 2D qualitative movement assessment of a deceleration task detects football players with high knee joint loading
- 10.1038/s41467-020-17807-z may be a valid DOI for title: Deep neural networks enable quantitative movement analysis using single-camera videos
- 10.2139/ssrn.3413035 may be a valid DOI for title: Clinical trial data transparency and GDPR compliance: Implications for data sharing and open innovation
- 10.1080/00140139.2015.1057238 may be a valid DOI for title: Comparison between low-cost marker-less and high-end marker-based motion capture systems for the computer-aided assessment of working ergonomics
- 10.2307/41410412 may be a valid DOI for title: Consumer acceptance and use of information technology: extending the unified theory of acceptance and use of technology
- 10.1152/japplphysiol.00772.2007 may be a valid DOI for title: Hypergravity resistance exercise: the use of artificial gravity as potential countermeasure to microgravity

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Pose2Sim: An open-source Python package for multiview markerless kinematics
Submitting author: @DavidPagnon
Handling editor: @danasolav (Active)
Reviewers: @lambdaloop, @jonmatthis, @CVHammond
Similarity score: 0.8215

3D reconstruction toolbox for behavior tracked with multiple cameras
Submitting author: @SwathiSheshadri
Handling editor: @cMadan (Active)
Reviewers: @danasolav, @sreschechtko
Similarity score: 0.7984

Sit2StandPy: An Open-Source Python Package for Detecting and Quantifying Sit-to-Stand Transitions Using an Accelerometer on the Lower Back
Submitting author: @LukasAdamowicz
Handling editor: @galessiorob (Active)
Reviewers: @jsgalan, @gweissman
Similarity score: 0.7977

Kinematics-vis: A Visualization Tool for the Mathematics of Human Motion
Submitting author: @heath-henninger
Handling editor: @adi3 (Active)
Reviewers: @destogl, @nnadeau
Similarity score: 0.7919

pytransform3d: 3D Transformations for Python
Submitting author: @AlexanderFabisch
Handling editor: @brainstorm (Retired)
Reviewers: @luizirber
Similarity score: 0.7861

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@davidpagnon
Copy link

From the above similar articles, it seems like LukasAdamowicz (Sit2StandPy) and SwathiSheshadri (pose-3d) could be a good fit for reviewing sports2d!
Maybe tuliofalmeida, melund, and/or alcantarar as well.

@editorialbot generate pdf

@davidpagnon
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Pose2Sim: An open-source Python package for multiview markerless kinematics
Submitting author: @DavidPagnon
Handling editor: @danasolav (Active)
Reviewers: @lambdaloop, @jonmatthis, @CVHammond
Similarity score: 0.8216

3D reconstruction toolbox for behavior tracked with multiple cameras
Submitting author: @SwathiSheshadri
Handling editor: @cMadan (Active)
Reviewers: @danasolav, @sreschechtko
Similarity score: 0.7985

Sit2StandPy: An Open-Source Python Package for Detecting and Quantifying Sit-to-Stand Transitions Using an Accelerometer on the Lower Back
Submitting author: @LukasAdamowicz
Handling editor: @galessiorob (Active)
Reviewers: @jsgalan, @gweissman
Similarity score: 0.7978

Kinematics-vis: A Visualization Tool for the Mathematics of Human Motion
Submitting author: @heath-henninger
Handling editor: @adi3 (Active)
Reviewers: @destogl, @nnadeau
Similarity score: 0.7920

pytransform3d: 3D Transformations for Python
Submitting author: @AlexanderFabisch
Handling editor: @brainstorm (Retired)
Reviewers: @luizirber
Similarity score: 0.7862

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @Kevin-Mattheus-Moerman is now the editor

@Kevin-Mattheus-Moerman
Copy link
Member

@davidpagnon thanks for this submission. I am currently looking into potential reviewers. Let me know if you have any suggestions for reviewers at this point. You can mention their GitHub handles here, but leave out the @ symbol.

@davidpagnon
Copy link

Hi Kevin, thank you for offering yourself as an editor!

I suggested a few in a previous comment, but of course, I'm open to anyone else.

From the above similar articles, it seems like LukasAdamowicz (Sit2StandPy) and SwathiSheshadri (pose-3d) could be a good fit for reviewing sports2d! Maybe tuliofalmeida, melund, and/or alcantarar as well.

P.S.: I just edited a github action, build was unsuccessful on certain distribution due to an incompatible package version. All builds are now successful.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Apr 2, 2024

@davidpagnon

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.

@Kevin-Mattheus-Moerman
Copy link
Member

@SwathiSheshadri, @lambdaloop, @cvhammond, @destogl, @moorepants, @modenaxe would you be interested in helping to review this submission for JOSS? The work features 2D join angle analysis from sport video footage.

Software: https://github.com/davidpagnon/Sports2D
Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06375/joss.06375/10.21105.joss.06375.pdf

@davidpagnon
Copy link

davidpagnon commented Apr 2, 2024

@davidpagnon

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2006.10204 is OK
- 10.1007/978-1-4842-4470-8 is OK
- 10.1038/s41746-023-00775-1 is OK
- 10.7326/0003-4819-157-1-201207030-00450 is OK
- 10.1109/TPAMI.2019.2929257 is OK
- 10.2307/2683591 is OK
- 10.1186/s40798-018-0139-y is OK
- 10.1007/s00167-021-06709-2 is OK
- 10.1038/s41467-020-17807-z is OK
- 10.1038/s41593-018-0209-y is OK
- 10.2139/ssrn.3413035 is OK
- 10.1080/24748668.2008.11868456 is OK
- 10.21105/joss.04362 is OK
- 10.1080/00140139.2015.1057238 is OK
- 10.1101/2022.07.07.499061 is OK
- 10.2307/41410412 is OK
- 10.7717/peerj.12995 is OK
- 10.1152/japplphysiol.00772.2007 is OK
- 10.1145/3603618 is OK

MISSING DOIs

- No DOI given, and none found for title: The OpenCV Library
- No DOI given, and none found for title: On the theory of filter amplifiers
- No DOI given, and none found for title: Kinovea - A microscope for your videos
- No DOI given, and none found for title: A 3D markerless protocol with action cameras – Key...
- No DOI given, and none found for title: Gait analysis: an introduction

INVALID DOIs

- None

@Kevin-Mattheus-Moerman
Copy link
Member

@SwathiSheshadri, @lambdaloop, @cvhammond, @destogl, @moorepants, @modenaxe would you be interested in helping to review this submission for JOSS? The work features 2D join angle analysis from sport video footage.

Software: https://github.com/davidpagnon/Sports2D
Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06375/joss.06375/10.21105.joss.06375.pdf

@davidpagnon
Copy link

Hi @Kevin-Mattheus-Moerman, I don't see any response and I'm not sure these guys saw the notification. What is the process usually in this case? Trying to contact them per email, or contact other authors?

@Kevin-Mattheus-Moerman
Copy link
Member

Hi @Kevin-Mattheus-Moerman, I don't see any response and I'm not sure these guys saw the notification. What is the process usually in this case? Trying to contact them per email, or contact other authors?

@davidpagnon apologies for the delay. I will get back to this shortly and yes I'll try to 1) remind them here once more, and 2) email a few.

@Kevin-Mattheus-Moerman
Copy link
Member

@SwathiSheshadri, @lambdaloop, @cvhammond, @destogl, @moorepants, @modenaxe would you be interested in helping to review this submission for JOSS? The work features 2D join angle analysis from sport video footage.

Software: https://github.com/davidpagnon/Sports2D
Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06375/joss.06375/10.21105.joss.06375.pdf

@lambdaloop
Copy link

Hello, thank you for pinging me again. I'm sorry I did miss the previous notification.
It looks interesting, but I don't have time to review this submission.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented May 25, 2024

@SwathiSheshadri, @cvhammond, @destogl, @moorepants, @modenaxe, @LukasAdamowicz @tuliofalmeida @melund @alcantarar

would you be interested in helping to review this submission for JOSS? The work features 2D join angle analysis from sport video footage.

Software: https://github.com/davidpagnon/Sports2D
Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06375/joss.06375/10.21105.joss.06375.pdf

@tuliofalmeida
Copy link

Hello Kevin, I'm available to review the paper after 11/06 if it's not a problem for you!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot add @tuliofalmeida as reviewer

@editorialbot
Copy link
Collaborator Author

@tuliofalmeida added to the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented May 27, 2024

@davidpagnon thanks for suggesting the authors of this submission: #6627 as reviewers. Although under different circumstances they could be suitable reviewers, because you are a reviewer for their submission, they cannot currently review yours as that would constitute a potential conflict of interest.

Hence @rmndrs89 and colleagues, unfortunately you cannot be a reviewer for this work. Thanks for offering to review though.

@Kevin-Mattheus-Moerman
Copy link
Member

@SwathiSheshadri, @cvhammond, @destogl, @moorepants, @modenaxe, @LukasAdamowicz @tuliofalmeida @melund @alcantarar @claaslendt

would you be interested in helping to review this submission for JOSS? The work features 2D join angle analysis from sport video footage.

Software: https://github.com/davidpagnon/Sports2D
Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06375/joss.06375/10.21105.joss.06375.pdf

@melund
Copy link

melund commented May 27, 2024

@Kevin-Mattheus-Moerman. Sorry, I will not have time to do this at the moment.

@LukasAdamowicz
Copy link

Unfortunately I am too busy as well

@claaslendt
Copy link

@Kevin-Mattheus-Moerman. Thanks for considering me. I am afraid that this is a bit outside my area of expertise.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented May 30, 2024

@SwathiSheshadri, @cvhammond, @destogl, @moorepants, @modenaxe, ,@tuliofalmeida, @alcantarar

would you be interested in helping to review this submission for JOSS? The work features 2D join angle analysis from sport video footage.

Software: https://github.com/davidpagnon/Sports2D
Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06375/joss.06375/10.21105.joss.06375.pdf

@Kevin-Mattheus-Moerman
Copy link
Member

@melund @LukasAdamowicz @claaslendt no worries, thanks for getting back to me.

@Kevin-Mattheus-Moerman
Copy link
Member

@evaherbst
Copy link

Thanks @Kevin-Mattheus-Moerman for the invitation to review.
I am stretched super thin for the next months with different projects so I cannot at this time, but please do contact me for future reviews.

@nicos1993
Copy link

@Kevin-Mattheus-Moerman Thanks for the invitation. I would like to help with this review.

Thanks,

Nicos

@johnjdavisiv
Copy link

@Kevin-Mattheus-Moerman Yes, I'm happy to help!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot add @nicos1993 as reviewer

@editorialbot
Copy link
Collaborator Author

@nicos1993 added to the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot add @johnjdavisiv as reviewer

@editorialbot
Copy link
Collaborator Author

@johnjdavisiv added to the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6849.

@Ipuch
Copy link

Ipuch commented Jun 5, 2024

Thanks, @Kevin-Mattheus-Moerman, I would have been glad to participate. Don't hesitate to ask me for a review next time.

@forceteck
Copy link

Thanks @Kevin-Mattheus-Moerman - I currently work with David, so there is a conflict of interest. Happy to review next time too.

@adrianrivadulla
Copy link

adrianrivadulla commented Jun 6, 2024 via email

@Kevin-Mattheus-Moerman
Copy link
Member

@Ipuch we can still add you if you like! We would welcome another reviewer, just let me know and I can still add you.

@Ipuch
Copy link

Ipuch commented Jun 6, 2024

Please add me only if you need the extra help.

@Kevin-Mattheus-Moerman
Copy link
Member

@Ipuch you're off the hook so. No worries. I might invite you for a future motion/biomechanics one :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jupyter Notebook pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests