Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: NGMT: NeuroGeriatric Motion Toolbox - An Open-Source Python Toolbox for Analyzing Neurological Motion Data from Various Recording Modalities #6627

Closed
editorialbot opened this issue Apr 16, 2024 · 35 comments
Closed

[PRE REVIEW]: NGMT: NeuroGeriatric Motion Toolbox - An Open-Source Python Toolbox for Analyzing Neurological Motion Data from Various Recording Modalities #6627

editorialbot opened this issue Apr 16, 2024 · 35 comments
Assignees
@aaa34169 @Kevin-Mattheus-Moerman @davidpagnon
Labels
pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 16, 2024 •
edited
Loading

Submitting author: @JuliusWelzel (Julius Welzel)
Repository: https://github.com/neurogeriatricskiel/NGMT
Branch with paper.md (empty if default branch):
Version: v0.0.4
Editor: @Kevin-Mattheus-Moerman
Reviewers: @aaa34169, @davidpagnon
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/206544a8549ddb295d0fbbd1fc898b3f"><img src="https://joss.theoj.org/papers/206544a8549ddb295d0fbbd1fc898b3f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/206544a8549ddb295d0fbbd1fc898b3f/status.svg)](https://joss.theoj.org/papers/206544a8549ddb295d0fbbd1fc898b3f)

Author instructions

Thanks for submitting your paper to JOSS @JuliusWelzel. Currently, there isn't a JOSS editor assigned to your paper.

@JuliusWelzel if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Apr 16, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.29 s (258.7 files/s, 450354.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              3              0              0         116689
Python                          25           1375           1893           4249
Markdown                        29            654              0           2160
Jupyter Notebook                11              0           3660            747
HTML                             1             32              1            396
TeX                              1             20              1            178
YAML                             4             20              6            167
TOML                             1              4              0             52
CSS                              1              2              0             10
-------------------------------------------------------------------------------
SUM:                            76           2107           5561         124648
-------------------------------------------------------------------------------

Commit count by author:

   155	Julius Welzel
   154	masoudabedinifar
    54	github-actions
    47	rmndrs89
    34	jwelzel
    27	Robbin Romijnders
    21	JuliusWelzel
     2	dependabot[bot]

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1120

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

On the license this is an OSI approved license: https://opensource.org/license/nposl-3-0

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @Kevin-Mattheus-Moerman is now the editor

@JuliusWelzel
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @JuliusWelzel, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@JuliusWelzel
Copy link

@Kevin-Mattheus-Moerman, thanks for taking over the editorial process of our manuscript.

For potential reviewer we would suggest

  1. sappelhoff - for his expertise in BIDS
  2. davidpagnon - for his expertise in biomechanics
  3. AKuederle - for his experience with python package handling

@JuliusWelzel
Copy link

Hi @Kevin-Mattheus-Moerman, is there currently anything we can do to support moving the review process along?

@Kevin-Mattheus-Moerman
Copy link
Member

@JuliusWelzel apologies for the delay so far. I am currently looking for reviewers for this work. I'll check your suggestions also. One point that worries me at the moment is the warning in your README: The toolbox is currently under development and is not yet ready for use.. Please can you clarify this? I am afraid this would make the work unacceptable for JOSS.

@JuliusWelzel
Copy link

@Kevin-Mattheus-Moerman, thanks for the feedback. We left this warning as the toolbox has not been peer-reviewed. From our point of view, it is ready for use since we submitted it to JOSS. I removed the warning in neurogeriatricskiel/KielMAT@36ed01e

@JuliusWelzel
Copy link

@Kevin-Mattheus-Moerman Any luck finding reviewers? We can make some more suggestions if help is wanted. :)

@Kevin-Mattheus-Moerman
Copy link
Member

@JuliusWelzel yes please if you could suggest any others that would be great. Apologies for the delay so far.

@Kevin-Mattheus-Moerman
Copy link
Member

@davidpagnon @sappelhoff @AKuederle @marcoghislieri @aaa34169

would you be interested in helping to review this submission for JOSS? The work is titled "NGMT: NeuroGeriatric Motion Toolbox - An Open-Source Python Toolbox for Analyzing Neurological Motion Data from Various Recording Modalities".

Software: https://github.com/neurogeriatricskiel/NGMT
Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06627/joss.06627/10.21105.joss.06627.pdf

JOSS reviews focus on evaluation of the software as well as the review of the very short paper. JOSS reviews happen in the open here on GitHub. See here for more information on our review process: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

If you are interested you can let me know here. Thanks!

@davidpagnon
Copy link

Sure, why not!

@aaa34169
Copy link

aaa34169 commented May 25, 2024 via email

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot add @aaa34169 as reviewer

@editorialbot
Copy link
Collaborator Author

@aaa34169 added to the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot add @davidpagnon as reviewer

@editorialbot
Copy link
Collaborator Author

@davidpagnon added to the reviewers list!

@sappelhoff
Copy link
Member

Thanks for the invite, but I have to decline the review due to conflict of interest, as stated here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html#joss-conflict-of-interest-policy

As a reviewer (or editor), COIs are your present or previous association with any authors of a submission: recent (past four years) collaborators in funded research or work that is published; and lifetime for the family members, business partners, and thesis student/advisor or mentor. In addition, your recent (past year) association with the same organization of a submitter is a COI, for example, being employed at the same institution.

@JuliusWelzel
Copy link

@Kevin-Mattheus-Moerman, thanks for moving this forward. We will get back with more reviewer suggestions. As two have accepted, how many more are needed?

@Kevin-Mattheus-Moerman
Copy link
Member

@JuliusWelzel the minimum is two. However I'll give it a bit more time to hopefully attract another. If I haven't found in the next couple of days, I'll start the review.

@marcoghislieri
Copy link

Thank you for considering me to review this submission. Unfortunately, due to my current commitments, I cannot review this paper at this moment.

Closed
@Kevin-Mattheus-Moerman
Copy link
Member

@JuliusWelzel to avoid further delay, I'll trigger the review now.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6842.

@aaa34169
Copy link

I am writing to inform you of an unfortunate bicycle accident that has impacted my ability to complete the assigned review by the original deadline. I anticipate that I will only be able to submit my review by the end of July

if this delay is too significant , please feel free to assign the review to another expert.

@Kevin-Mattheus-Moerman
Copy link
Member

@aaa34169 sorry to hear about that accident. I think we can wait for you to finish your review. Take your time and get well soon!

@davidpagnon
Copy link

@aaa34169 Sorry to hear that, I hope you'll get better soon, but more importantly, well!

@JuliusWelzel
Copy link

@aaa34169 Sorry to hear, you hopefully get well soon.

@Kevin-Mattheus-Moerman, would it be possible to find a reviewer available earlier? That really would help us.

Best,
Julius

@Kevin-Mattheus-Moerman
Copy link
Member

@aaa34169 I hope you are doing well. Could you provide an update on where things stand? If you need more time let us know. Thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaa34169 aaa34169

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman

@davidpagnon davidpagnon

Labels
pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@aaa34169 @Kevin-Mattheus-Moerman @sappelhoff @JuliusWelzel @davidpagnon @marcoghislieri @editorialbot