-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Sports2D: Compute 2D joint and segment angles from your smartphone #6849
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Review checklist for @johnjdavisivConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@tuliofalmeida, @nicos1993, @johnjdavisiv This is where the review takes place. To get started, like @johnjdavisiv did just now, you can call |
Review checklist for @nicos1993Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @tuliofalmeidaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Apologies for the delay in this review. I will complete by the end of this week if that is okay? Nicos |
Hi, thank you Nicos and the other reviewers. To @Kevin-Mattheus-Moerman: @hunminkim98 and I are currently working to make it run in real time, I wonder if it's worth completing the review with the library the way it is, or if it's better to wait? Note that it could be a couple months because it's not the hottest priority right now. sports2d_demo2.mp4 |
@davidpagnon I suggest we continue with the current state of things as submitted. If you've implemented the features before this review is over we can revisit this. In any case I recommend you implement it with a clear example for instance, so that testing this new functionality is quick and simple, and would not take a lot of additional time. |
@tuliofalmeida, @nicos1993, @johnjdavisiv thanks again for your help with this review. Would you be able to provide a quick update on where things stand? Are there some key points the authors should work on? Thanks! |
Hey @Kevin-Mattheus-Moerman I'm planning to finish this week! |
Hello @Kevin-Mattheus-Moerman, I have tested the software using installation option 2 and followed the example, I can confirm the instructions are very clear and the demonstration ran smoothly with no issues. I believe this software will be very useful for coaches or practitioners wishing to perform a 2D automated kinematic analysis. I do have a couple of suggestions that the author may wish to consider.
Best wishes, Nicos Haralabidis |
@nicos1993 thanks for your review and comments. Could you respond to the authors reply ☝️ ? Let me know if you are now happy (some of your boxes are not ticked) with this submission or if there are any other points that the authors should work on. Thanks! |
@johnjdavisiv thanks for your help with this review. Would you be able to finalise your review shortly? We do have two nearly completed reviews, but if you are able to complete yours that would be great. Thanks! |
@tuliofalmeida it looks like you've ticked all boxes. Are you happy to recommend acceptance of this work for JOSS? Thanks for your help! |
@Kevin-Mattheus-Moerman Will be a bit of a stretch to finish it this week, but I can get it done by the end of next! |
@johnjdavisiv thanks. Let me know if you have any questions or if you are good to proceed. |
@editorialbot generate pdf |
@editorialbot set 0.4.6 as version |
I'm sorry @davidpagnon, I'm afraid I can't do that. That's something only editors are allowed to do. |
@editorialbot set v0.4.6 as version |
Done! version is now v0.4.6 |
@editorialbot set 10.5281/zenodo.7903962 as archive |
Done! archive is now 10.5281/zenodo.7903962 |
@davidpagnon can you update the archive listed license to match your project license? |
Oh sorry yes, I missed it! Done now. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5905, then you can now move forward with accepting the submission by compiling again with the command |
I noticed a typo (two stars ** that had to be removed) and slightly rephrased something in the last paragraph of the statement of need. It probably does not matter if this is too late. |
@davidpagnon not too late :) I still have a couple of checks to do as well. The paper will be updated still so. |
@davidpagnon I now speak to you as an AEiC for JOSS to help process the work for acceptance. I will now process some final checks: Checks on repository
Checks on review issue
Checks on archive
Checks on paper
|
@davidpagnon I will now proceed to accept this since all checks are done |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thank you everyone, reviewers and editor for your contribution to this paper! |
@davidpagnon congratulations on this JOSS publication. I'd like to say thanks to reviewers: @tuliofalmeida, @nicos1993 !!!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @davidpagnon (David Pagnon)
Repository: https://github.com/davidpagnon/Sports2D
Branch with paper.md (empty if default branch):
Version: v0.4.6
Editor: @Kevin-Mattheus-Moerman
Reviewers: @tuliofalmeida, @nicos1993
Archive: 10.5281/zenodo.7903962
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@tuliofalmeida & @nicos1993 & @johnjdavisiv, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @nicos1993
📝 Checklist for @johnjdavisiv
📝 Checklist for @tuliofalmeida
The text was updated successfully, but these errors were encountered: