-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: LINFA: a Python library for variational inference with normalizing flow and annealing #6309
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
👋🏼 @robmoss & @selimfirat this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines (there : https://joss.readthedocs.io/en/latest/reviewer_guidelines.html) The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@lrnv) if you have any questions/concerns. |
|
Review checklist for @robmossConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@robmoss I see your review already started, how is it going ? @selimfirat It's been two weeks did you have the time to take a look at this submission ? If you need more time, simply tell me I can setup automatic reminders for you if you want. |
@lrnv thanks for checking in. I've made some progress, but have had to take some personal leave due to unforeseen circumstances. I will return to work next week, and continue my review. I identified a packaging issue, which is related to the paper but only applies to the software itself. Should I ask the authors to respond to this issue as part of the review process? Thanks in advance for your advice :) |
@robmoss thanks for your reply. It is definitely expected from you to raise issues that apply to the software: the subject an the content of the review should be the software, the paper is just a side-effect IMHO. So if you found bugs or problems with the software, yes you can ask the authors to fix things as part of the review process. You can ask for new features if you think they would be logically inserted into the current project, or even for more detailled documentation, refactoring of API or even refactoring of internals, if you think that some other decision would have made more sense. Sky is the limit. |
@lrnv Thanks very much for your advice. I've noted a number of small things to raise with the authors (mostly related to the few remaining unchecked items in my checklist) and will file a few issues in their repo later this week. |
Review checklist for @selimfiratConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot commands |
Hello @selimfirat, here are the things you can ask me to do:
|
Hello again. I requested revisions by creating issues in the repository regarding the unchecked items: https://github.com/desResLab/LINFA/issues Now, I am waiting until the author makes neccessary changes. Is there any other action I should take? |
@selimfirat Well done, this is great. 👍 Note that you are allowed and encouraged to also make comments and revisions requests about the code itself and not only the paper (this is the main point of JOSS reviews: to get reviewers oppinon and knowledge on the codebase). E.g., if you think the tests cases are not good enough, or if some implementation of a functionality looks clunky to you, or if you think something should be done in some other manner, like an API that does not look right etc... or, more trivially, if you find a straight up bug. Sky is your limit. Otherwise, everything looks good on my part :) |
@lrnv Likewise, I've created issues for each of my comments and questions, I'm now waiting for the authors to respond. |
@daneschi it has been two weeks. Would it be possible to have a status update on the issues that were raised ? |
@editorialbot commands |
Hello @lrnv, here are the things you can ask me to do:
|
|
I checked the repository and updated the checklist, in case still needed :). All issues seem resolved. |
Thanks @lrnv. Is there anything else needed on my end?
…On Tue, Apr 2, 2024 at 6:06 AM Selim Firat Yilmaz ***@***.***> wrote:
I checked the repository and updated the checklist, in case still needed
:). All issues seem resolved.
—
Reply to this email directly, view it on GitHub
<#6309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJL6ENWZWZOFIDZN23UUVTY3J7JPAVCNFSM6AAAAABCSWRGUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRGU4TEMZZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@daneschi Not for the moment, you have to wait for the aEiC to take care of the publication. Congratulation :) |
Thank you very much for all your Help and Kind Supervision throughout this
review!
…On Tue, Apr 2, 2024 at 10:29 AM Oskar Laverny ***@***.***> wrote:
@daneschi <https://github.com/daneschi> Not for the moment, you have to
wait for the aEiC to take care of the publication. Congratulation :)
—
Reply to this email directly, view it on GitHub
<#6309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJL6EMOBEIIMZPT7OU6RCLY3K6GNAVCNFSM6AAAAABCSWRGUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSGE4TSMJSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
👋 folks. A few things with the paper here: It looks to be 'off' in a few places:
|
Thanks a lot @arfon for catching theses. I will be more careful in the future w.r.t. text length. Since here ~75% of it is in appendix, I thought it was OK, but reading the guidelines once more, I see that it is not. |
Hi @lrnv should I fix these problems in the md file?
Sorry for the length, I also thought it was OK to have more material in the
appendix.
Thanks
…On Thu, Apr 4, 2024 at 11:03 AM Oskar Laverny ***@***.***> wrote:
Thanks a lot @arfon <https://github.com/arfon> for catching theses. I
will be more careful in the future w.r.t. text length. Since here ~75% of
it is in appendix, I thought it was OK, but reading the guidelines once
more, I see that it is not.
—
Reply to this email directly, view it on GitHub
<#6309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJL6EMMUAPLQGC6TCSKVG3Y3VTVZAVCNFSM6AAAAABCSWRGUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXGQ3DENRUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes please. You are not publishing in the AAS ? Thus the AAS section of your .md file should not be there. |
Thank you @lrnv I have fixed both issues.
…On Thu, Apr 4, 2024 at 11:21 AM Oskar Laverny ***@***.***> wrote:
Yes please. You are not publishing in the AAS ? Thus the AAS section of
your .md file should not be there.
—
Reply to this email directly, view it on GitHub
<#6309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJL6EKWN7UGV5WEBRP6IRTY3VVXTAVCNFSM6AAAAABCSWRGUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXGUYDGNBTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5214, then you can now move forward with accepting the submission by compiling again with the command |
|
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@robmoss, @selimfirat – many thanks for your reviews here and to @lrnv for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @daneschi – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you all very much for your Kind Assistance with this review!
Thanks @robmoss, @selimfirat for your comments and @lrnv for your editorial
supervision and your patience!
…On Fri, Apr 5, 2024 at 4:20 PM The Open Journals editorial robot < ***@***.***> wrote:
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉
If you would like to include a link to your paper from your README use the
following code snippets:
Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06309/status.svg)](https://doi.org/10.21105/joss.06309)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06309">
<img src="https://joss.theoj.org/papers/10.21105/joss.06309/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06309/status.svg
:target: https://doi.org/10.21105/joss.06309
This is how it will look in your documentation:
[image: DOI] <https://doi.org/10.21105/joss.06309>
*We need your help!*
The Journal of Open Source Software is a community-run journal and relies
upon volunteer effort. If you'd like to support us please consider doing
either one (or both) of the the following:
- Volunteering to review for us sometime in the future. You can add
your name to the reviewer list here:
https://reviewers.joss.theoj.org/join
- Making a small donation to support our running costs here:
https://numfocus.org/donate-to-joss
—
Reply to this email directly, view it on GitHub
<#6309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJL6EI6L46RJXKVPCS5JMTY34BPNAVCNFSM6AAAAABCSWRGUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGU3DOMRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Submitting author: @daneschi (Daniele E. Schiavazzi)
Repository: https://github.com/desResLab/LINFA
Branch with paper.md (empty if default branch): master
Version: 1.5.1
Editor: @lrnv
Reviewers: @robmoss, @selimfirat
Archive: 10.5281/zenodo.10883597
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@robmoss & @selimfirat, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lrnv know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @robmoss
📝 Checklist for @selimfirat
The text was updated successfully, but these errors were encountered: