Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: LINFA: a Python library for variational inference with normalizing flow and annealing #6108

Closed
editorialbot opened this issue Dec 1, 2023 · 41 comments
Closed

[PRE REVIEW]: LINFA: a Python library for variational inference with normalizing flow and annealing #6108

editorialbot opened this issue Dec 1, 2023 · 41 comments
Assignees
@robmoss @selimfirat @lrnv
Labels
Jupyter Notebook pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 1, 2023 •
edited
Loading

Submitting author: @daneschi (Daniele E. Schiavazzi)
Repository: https://github.com/desResLab/LINFA
Branch with paper.md (empty if default branch): master
Version: v1.3.3
Editor: @lrnv
Reviewers: @robmoss, @selimfirat
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/adb20d3d808e8b369e827b5d9fba277b"><img src="https://joss.theoj.org/papers/adb20d3d808e8b369e827b5d9fba277b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/adb20d3d808e8b369e827b5d9fba277b/status.svg)](https://joss.theoj.org/papers/adb20d3d808e8b369e827b5d9fba277b)

Author instructions

Thanks for submitting your paper to JOSS @daneschi. Currently, there isn't a JOSS editor assigned to your paper.

@daneschi if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Dec 1, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.07 s (970.1 files/s, 195101.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          26           1011            893           2939
XML                              6              0            129           1842
Jupyter Notebook                 2              0           4069            440
Markdown                         2            124              0            416
TeX                              2             45              0            379
reStructuredText                19            158            336             93
YAML                             3             14             14             63
TOML                             1              5              1             29
DOS Batch                        1              8              1             26
Bourne Shell                     2              1              0             16
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            65           1370           5450           6252
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 5049

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/b978-0-08-051581-6.50057-x may be a valid DOI for title: Stochastic relaxation, Gibbs distributions, and the Bayesian restoration of images
- 10.2172/4390578 may be a valid DOI for title: Equation of state calculations by fast computing machines
- 10.1093/oso/9780198509936.003.0015 may be a valid DOI for title: Monte Carlo sampling methods using Markov chains and their applications
- 10.21236/ada208388 may be a valid DOI for title: Sampling-based approaches to calculating marginal densities
- 10.1561/9781601981851 may be a valid DOI for title: Graphical models, exponential families, and variational inference
- 10.1109/tpami.2020.2992934 may be a valid DOI for title: Normalizing flows: An introduction and review of current methods
- 10.1016/j.jcp.2022.111454 may be a valid DOI for title: Variational inference with NoFAS: Normalizing flow with adaptive surrogate for computationally expensive models
- 10.1615/int.j.uncertaintyquantification.2022043110 may be a valid DOI for title: AdaAnn: Adaptive Annealing Scheduler for Probability Density Approximation
- 10.1016/s0951-8320(02)00229-6 may be a valid DOI for title: Theorems and examples on high dimensional model representation
- 10.1016/0041-5553(67)90144-9 may be a valid DOI for title: On the distribution of points in a cube and the approximate evaluation of integrals

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Linopy: Linear optimization with n-dimensional labeled variables
Submitting author: @fabianhofmann
Handling editor: @Fei-Tao (Active)
Reviewers: @torressa, @g4brielvs
Similarity score: 0.8094

dfba: Software for efficient simulation of dynamic flux-balance analysis models in Python
Submitting author: @davidtourigny
Handling editor: @marcosvital (Active)
Reviewers: @jdbrunner, @pstjohn, @synchon
Similarity score: 0.7978

Sapsan: Framework for Supernovae Turbulence Modeling with Machine Learning
Submitting author: @pikarpov-lanl
Handling editor: @dfm (Active)
Reviewers: @kburns, @milescranmer
Similarity score: 0.7976

High-performance neural population dynamics modeling enabled by scalable computational infrastructure
Submitting author: @a9p
Handling editor: @emdupre (Active)
Reviewers: @richford, @tachukao
Similarity score: 0.7970

Capytaine: a Python-based linear potential flow solver
Submitting author: @mancellin
Handling editor: @leouieda (Retired)
Reviewers: @mikaem, @harpolea
Similarity score: 0.7961

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Dec 9, 2023

@daneschi - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Dec 9, 2023
@daneschi
Copy link

daneschi commented Dec 9, 2023 via email

@daneschi
Copy link

daneschi commented Jan 9, 2024 via email

@arfon
Copy link
Member

arfon commented Jan 9, 2024

Nothing to do here. The submission is waitlisted until we have an editor that has capacity to handle this submission.

@daneschi
Copy link

daneschi commented Jan 9, 2024 via email

@arfon
Copy link
Member

arfon commented Jan 20, 2024 •
edited
Loading

@editorialbot invite @lrnv as editor

👋 @lrnv – would you be willing to edit this submission for JOSS?

/ cc @vissarion for visibility.

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@lrnv
Copy link

lrnv commented Jan 20, 2024

@assign me as editor

@lrnv
Copy link

lrnv commented Jan 20, 2024

@daneschi Hey !

Do you by chance know the github handle of the people you listed as potential reviewers ?

@daneschi
Copy link

daneschi commented Jan 20, 2024 via email

@arfon
Copy link
Member

arfon commented Jan 20, 2024

@assign me as editor

@lrnv - you need to do @editorialbot assign me as editor

@arfon
Copy link
Member

arfon commented Jan 20, 2024

@daneschi – it looks like GitHub might have filtered out the email addresses of the people you listed here. Perhaps you could share them directly with @lrnv ?

@arfon arfon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 20, 2024
@arfon
Copy link
Member

arfon commented Jan 20, 2024

@editorialbot assign @lrnv as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @lrnv is now the editor

@daneschi
Copy link

daneschi commented Jan 20, 2024 via email

@lrnv
Copy link

lrnv commented Jan 22, 2024

@arfon Thanks for helping out.

@daneschi I sent a few mails, let's wait a bit for potential responses.

@daneschi
Copy link

daneschi commented Jan 22, 2024 via email

@lrnv
Copy link

lrnv commented Jan 29, 2024

@daneschi no-one responded, so I am going to try to find reviewers otherwise.

@lrnv
Copy link

lrnv commented Jan 29, 2024

👋 @FabianHofmann & @mancellin & @davidtourigny, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@FabianHofmann
Copy link

@lrnv I think I don't have the capacity to make a review in the next few months, sorry...

@mancellin
Copy link

@lrnv Thank you for the proposal, but this paper is a bit too far away from my expertise for me to provide a useful review.

@lrnv
Copy link

lrnv commented Jan 29, 2024

👋 @daniel-dodd @vankesteren @robmoss, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: joss.readthedocs.io/en/latest/review_criteria.html

@vankesteren
Copy link

Sorry, have just accepted another JOSS review (just waiting on being assigned). Good luck!!

@davidtourigny
Copy link

davidtourigny commented Jan 29, 2024 via email

@daneschi
Copy link

daneschi commented Jan 29, 2024 via email

@lrnv
Copy link

lrnv commented Jan 30, 2024

👋 @selimfirat, @ldliao, @atzberg, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: joss.readthedocs.io/en/latest/review_criteria.html

@robmoss
Copy link

robmoss commented Jan 30, 2024

👋 @daniel-dodd @vankesteren @robmoss, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: joss.readthedocs.io/en/latest/review_criteria.html

I have limited familiarity with variational inference, but I can review this paper. This will be my first JOSS review, so I may have some questions about the review criteria.

@selimfirat
Copy link

👋 @selimfirat, @ldliao, @atzberg, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: joss.readthedocs.io/en/latest/review_criteria.html

Thanks for the invitation. I am interested in reviewing it.

I have some background knowledge on the topic of the paper, but this will be my first time reviewing for JOSS.

@lrnv
Copy link

lrnv commented Jan 31, 2024

@robmoss, @selimfirat Do not fear the review process it is quite straightforward and correctly documented, you'll see. Thanks for your interests, let's start the' review in another thread

@lrnv
Copy link

lrnv commented Jan 31, 2024

@editorialbot add @robmoss as reviewer

@editorialbot
Copy link
Collaborator Author

@robmoss added to the reviewers list!

@lrnv
Copy link

lrnv commented Jan 31, 2024

@editorialbot add @selimfirat as reviewer

@editorialbot
Copy link
Collaborator Author

@selimfirat added to the reviewers list!

@lrnv
Copy link

lrnv commented Jan 31, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmoss robmoss

@selimfirat selimfirat

@lrnv lrnv

Labels
Jupyter Notebook pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@arfon @robmoss @vankesteren @daneschi @selimfirat @lrnv @FabianHofmann @mancellin @davidtourigny @editorialbot