-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: BurnMan -- a Python toolkit for planetary geophysics, geochemistry and thermodynamics #5389
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋 @kaylai and @simonwmatthews Welcome to JOSS and thanks for agreeing to review! The comments from @editorialbot above outline the review process, which takes place in this thread (possibly with issues filed in the BurnMan repository). I'll be watching this thread if you have any questions. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention this issue so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for reviews to be completed within a month or two. Please let me know if you require some more time. We can also use editorialbot to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@jedbrown) if you have any questions/concerns. |
Review checklist for @simonwmatthewsConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @kaylaiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot commands |
Hello @kaylai, here are the things you can ask me to do:
|
I have completed my review of Burnman. I recommend that Burnman should be accepted for publication following resolution of the issues I raised on the repository (which all reference this issue). |
@editorialbot generate pdf |
@bobmyhill Could you update the metadata for your archive so the author list matches that of the paper? |
@jedbrown Yes, sorry. Done! |
@editorialbot set 10.5281/zenodo.8104293 as archive |
Done! archive is now 10.5281/zenodo.8104293 |
@editorialbot recommend-accept |
|
|
Element isbn: [facet 'minLength'] The value has a length of '9'; this underruns the allowed minimum length of '10'. |
@bobmyhill I think you can just remove that |
@jedbrown Done! Thanks for checking the source of the error. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4370, then you can now move forward with accepting the submission by compiling again with the command |
@jedbrown Brilliant, the proof looks good to me, with the exception of a couple of typos (now fixed in the paper branch). |
@jedbrown is this ok now? Thank you for all your efforts over the last few months :) |
Hi @bobmyhill! I am here to finalize the acceptance process.
|
Everything looks good so we are done! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @bobmyhill!! Many thanks to editor @jedbrown and reviewers @simonwmatthews and @kaylai for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @bobmyhill (Robert Myhill)
Repository: https://github.com/geodynamics/burnman
Branch with paper.md (empty if default branch): paper
Version: v1.2.0
Editor: @jedbrown
Reviewers: @simonwmatthews, @kaylai
Archive: 10.5281/zenodo.8104293
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@simonwmatthews & @kaylai, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jedbrown know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @simonwmatthews
📝 Checklist for @kaylai
The text was updated successfully, but these errors were encountered: