Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuscript: Text suggestions #531

Closed
kaylai opened this issue May 25, 2023 · 2 comments
Closed

Manuscript: Text suggestions #531

kaylai opened this issue May 25, 2023 · 2 comments

Comments

@kaylai
Copy link

kaylai commented May 25, 2023

Some suggestions for changes to the manuscript.

  • Since BurnMan has been published in previous iterations, it would be useful to add even just a sentence explaining what the major update in functionality is to this version compared to previously published ones. Particularly for users wanting to cite BurnMan (i.e., if they have used BurnMan before they would have likely cited the 2014 G3 paper and maybe the newer zenodo). What is the difference between the version in the 2014 paper and this one?
  • Second paragraph bulleted list: Use of "many" and "several" is vague. Can you state exactly how many?
  • Figure 4 (Profile through planet Zog): I suggest defining PREM and being more specific in the caption, for example: "Depth dependent changes to density, gravity, pressure, and temperature are shown for Planet Zog (solid blue line) and compared with the Preliminary Reference Earth Model (PREM; dotted orange line) for density, pressure, and gravity. The geotherm of Planet Zog is compared to several from the literature." I would also use a different color for S1977 since a dotted orange line is used for PREM in the other plots.
  • The Figure 5 caption needs to be clarified related to Manuscript: Improve clarity on mineral phase proportion calculations #526
  • Should MELTS be included in the list of Gibbs minimization codes?

In reference to: openjournals/joss-reviews#5389

@bobmyhill
Copy link
Member

bobmyhill commented Jun 19, 2023

  • add a sentence on major updates in functionality relative to 2014 paper
  • specify number of implemented things (second paragraph bulleted list)
  • Zog example: define PREM
  • Fig 4 caption: "Depth dependent changes to density, gravity, pressure, and temperature are shown for Planet Zog (solid blue line) and compared with the Preliminary Reference Earth Model (PREM; dotted orange line) for density, pressure, and gravity. The geotherm of Planet Zog is compared to several from the literature."
  • Fig 4: Use different colour for S1977
  • Fig 5 caption: see Manuscript: Improve clarity on mineral phase proportion calculations #526
  • Include MELTS in the list of Gibbs minimization codes

@bobmyhill
Copy link
Member

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants