Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: **geostan**: An R package for Bayesian spatial analysis #4716

Closed
editorialbot opened this issue Aug 28, 2022 · 103 comments
Closed

[REVIEW]: **geostan**: An R package for Bayesian spatial analysis #4716

editorialbot opened this issue Aug 28, 2022 · 103 comments
Assignees
Labels
accepted C++ published Papers published in JOSS R recommend-accept Papers recommended for acceptance in JOSS. review Shell Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 28, 2022

Submitting author: @ConnorDonegan (Connor Donegan)
Repository: https://github.com/ConnorDonegan/geostan
Branch with paper.md (empty if default branch): JOSS
Version: v0.4.1
Editor: @jbytecode
Reviewers: @wcjochem, @becarioprecario
Archive: 10.5281/zenodo.7311716

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b"><img src="https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b/status.svg)](https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@wcjochem & @becarioprecario, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @becarioprecario

📝 Checklist for @wcjochem

@editorialbot editorialbot added C++ R review Shell Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Aug 28, 2022
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.11 s (828.9 files/s, 146986.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            41           1300            133           6559
R                               29            213           2464           3141
TeX                              3             63              0            493
CSS                              3             98             52            442
JavaScript                       3             64             32            256
Markdown                         3             93              0            240
Rmd                              3            191            295            125
XML                              1              0              0            123
YAML                             3              3              4             85
SVG                              1              0              1             11
Bourne Shell                     2              4              2              4
C/C++ Header                     1              0              1              0
-------------------------------------------------------------------------------
SUM:                            93           2029           2984          11479
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1047

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jbytecode
Copy link

Dear @wcjochem and @becarioprecario

This is the review thread. Firstly, type

@editorialbot generate my checklist

to generate your own checklist. In that checklist, there are 20 check items. Whenever you complete the corresponding task, you can check off them. The review process is interactive so you can always interact with the authors, reviewers, and the editor. You can also create issues and pull requests in the target repo. Please do mention this thread's URL in the issues so we can keep tracking what is going on out of our world.

Please do not hesitate to ask me anything, anytime.

Thank you in advance!

@jbytecode
Copy link

Dear @wcjochem and @becarioprecario

Could you please update your status on how is going your review and generate your task lists?

Thank you in advance.

@jbytecode
Copy link

@editorialbot remind @wcjochem in two days

@editorialbot
Copy link
Collaborator Author

Reminder set for @wcjochem in two days

@jbytecode
Copy link

@editorialbot remind @becarioprecario in two days

@editorialbot
Copy link
Collaborator Author

Reminder set for @becarioprecario in two days

@jbytecode
Copy link

Thanks @editorialbot !

@editorialbot
Copy link
Collaborator Author

You are welcome

@editorialbot
Copy link
Collaborator Author

👋 @wcjochem, please update us on how your review is going (this is an automated reminder).

@editorialbot
Copy link
Collaborator Author

👋 @becarioprecario, please update us on how your review is going (this is an automated reminder).

@ConnorDonegan
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jbytecode
Copy link

@wcjochem, @becarioprecario - could you please update your status?

Can I kindly ask you to create your check list first?

Thank you in advance.

@wcjochem
Copy link

Hi @jbytecode when I agreed to review this submission I said I couldn't start until after 15 September. So I have only started my review and it is ongoing. Thanks.

@jbytecode
Copy link

@wcjochem - I am so sorry for bothering and pinging you too much, my bad! I totally forgot your deadline. Thank you for reminding that.

@jbytecode
Copy link

@becarioprecario - could you please update your status? We have failed to get a life signal from you. Setting a deadline for us would be great, if possible. Thank you in advance.

@jbytecode
Copy link

Dear @becarioprecario,

This is the last reminder. Since you never sent a response, I assume that you are so much busy to reply messages, and/or you are not able to receive notifications. If you don't set a deadline for us until 15th October, I will try to find another reviewer for this issue.

Thank you in advance.

@becarioprecario
Copy link

becarioprecario commented Oct 13, 2022 via email

@jbytecode
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@ConnorDonegan
Copy link

Thanks @jbytecode, @wcjochem and @jbytecode for a smooth and productive editorial experience.

@editorialbot
Copy link
Collaborator Author

⚠️ Error preparing paper acceptance. The generated XML metadata file is invalid.

ID tblU003Amodels already defined

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.1093/biomet/10.1.179 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1111/gean.12215 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.2139/ssrn.2420725 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.1111/rssa.12378 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1111/j.1467-9868.2008.00700.x is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- None

INVALID DOIs

- None

@jbytecode
Copy link

@openjournals/dev - I need your help, thank you in advance!

@tarleb
Copy link

tarleb commented Nov 11, 2022

This looks like a pandoc bug. As a workaround, the \label should be moved directly below the \caption of the table.

@jbytecode
Copy link

@ConnorDonegan - could you please help changing the markdown as suggested?

@jbytecode
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3717, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Nov 11, 2022
@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.1093/biomet/10.1.179 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1111/gean.12215 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.2139/ssrn.2420725 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.1111/rssa.12378 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1111/j.1467-9868.2008.00700.x is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- None

INVALID DOIs

- None

@arfon
Copy link
Member

arfon commented Nov 16, 2022

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.04716 joss-papers#3730
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04716
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Nov 16, 2022
@arfon
Copy link
Member

arfon commented Nov 16, 2022

@wcjochem, @becarioprecario – many thanks for your reviews here and to @jbytecode for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@ConnorDonegan – your paper is now accepted and published in JOSS ⚡🚀💥

@arfon arfon closed this as completed Nov 16, 2022
@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04716/status.svg)](https://doi.org/10.21105/joss.04716)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04716">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04716/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04716/status.svg
   :target: https://doi.org/10.21105/joss.04716

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted C++ published Papers published in JOSS R recommend-accept Papers recommended for acceptance in JOSS. review Shell Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences
Projects
None yet
Development

No branches or pull requests

7 participants