Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Connectome Mapper 3: A Flexible and Open-Source Pipeline Software for Multiscale Multimodal Human Connectome Mapping #4248

Closed
editorialbot opened this issue Mar 17, 2022 · 58 comments
Assignees
Labels
accepted Dockerfile published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Shell

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 17, 2022

Submitting author: @sebastientourbier (Sebastien Tourbier)
Repository: https://github.com/connectomicslab/connectomemapper3
Branch with paper.md (empty if default branch):
Version: v3.0.4
Editor: @osorensen
Reviewers: @adbartni, @jsheunis
Archive: 10.5281/zenodo.6645256

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/fa1f416a4a6c23fe19bda6f36f123c1e"><img src="https://joss.theoj.org/papers/fa1f416a4a6c23fe19bda6f36f123c1e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/fa1f416a4a6c23fe19bda6f36f123c1e/status.svg)](https://joss.theoj.org/papers/fa1f416a4a6c23fe19bda6f36f123c1e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@adbartni & @jsheunis, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @jsheunis

📝 Checklist for @adbartni

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=1.34 s (126.1 files/s, 93677.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              3              0             25          65623
Python                          95           6525           9108          25397
reStructuredText                18           1331            409           2152
XML                              2              0              0           1854
YAML                             9             77            115           1720
Jupyter Notebook                 7              0           5607           1196
INI                             10             54              0            917
CSS                              1              0              9            723
TeX                              1             60              0            668
Markdown                         3             81              0            493
HTML                             3             50              2            314
JSON                             6              0              0            228
Dockerfile                       1             43            111            192
DOS Batch                        1             23              1            166
make                             1             24              6            123
Bourne Shell                     7             15             40             66
JavaScript                       1              0              1              1
-------------------------------------------------------------------------------
SUM:                           169           8283          15434         101833
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 2739

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.3475969 is OK
- 10.1016/J.NEUROIMAGE.2011.08.056 is OK
- 10.1038/nn.4500 is OK
- 10.5281/zenodo.3571874 is OK
- 10.3389/fninf.2019.00001 is OK
- 10.1038/s41592-018-0235-4 is OK
- 10.1038/nn.4502 is OK
- 10.1371/journal.pone.0048121 is OK
- 10.3389/conf.fninf.2013.09.00042 is OK
- 10.1016/j.neuroimage.2015.04.042 is OK
- 10.1101/188706 is OK
- 10.1016/j.neuroimage.2006.01.021 is OK
- 10.1016/j.neuroimage.2015.02.065 is OK
- 10.1371/journal.pcbi.1005209 is OK
- 10.1146/annurev-biodatasci-072018-021237 is OK
- 10.3389/fninf.2014.00008 is OK
- 10.1162/netn_e_00052 is OK
- 10.1016/j.neuroimage.2012.01.021 is OK
- 10.5075/epfl-thesis-3230 is OK
- 10.1016/J.NEUROIMAGE.2011.09.015 is OK
- 10.1016/j.clinph.2020.09.018 is OK
- 10.1038/sdata.2018.270 is OK
- 10.1016/j.jneumeth.2011.09.031 is OK
- 10.3389/fnins.2013.00267 is OK
- 10.1016/j.neuroimage.2019.116137 is OK
- 10.3389/fninf.2011.00013 is OK
- 10.1038/s41592-021-01185-5 is OK
- 10.5281/ZENODO.3712762 is OK
- 10.1371/journal.pone.0177459 is OK
- 10.21105/joss.01294 is OK
- 10.1038/sdata.2016.44 is OK
- 10.1371/journal.pcbi.0010042 is OK
- 10.1016/j.clinph.2019.09.006 is OK
- 10.1038/nn.4550 is OK
- 10.1016/j.nicl.2020.102336 is OK
- 10.1016/j.neuroimage.2020.117137 is OK
- 10.1162/netn_a_00147 is OK
- 10.1002/hbm.25365 is OK
- 10.1016/j.neuroimage.2021.118611 is OK
- 10.1162/netn_a_00218 is OK
- doi10.18112/openneuro.ds003505.v1.1.1 is OK
- 10.1038/s41597-021-01116-1 is OK
- 10.1016/j.clinph.2021.10.008 is OK
- 10.1016/j.neuroimage.2009.10.003 is OK
- 10.12688/f1000research.20887.3 is OK
- 10.1101/gr.1239303 is OK
- 10.1101/2022.01.31.478189 is OK
- 10.1162/netn_a_00114 is OK
- 10.1073/PNAS.1922248117 is OK
- 10.1016/j.media.2007.06.004 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jsheunis
Copy link

jsheunis commented Mar 29, 2022

Review checklist for @jsheunis

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/connectomicslab/connectomemapper3?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@sebastientourbier) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@jsheunis
Copy link

jsheunis commented Apr 8, 2022

@osorensen @sebastientourbier

Review update: I've checked most of the boxes in my checklist. The ones that are still open are dependent on open issues, particularly:

@sebastientourbier
Copy link

Dear @jsheunis,

Thank you a lot for the time you spent reviewing CMP3 and its paper!
I am going to address your issues next week and I will reply directly inside them for the sake of clarity.
I will let you all know as soon as it is done.

Best regards

@adbartni
Copy link

adbartni commented Apr 18, 2022

Review checklist for @adbartni

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/connectomicslab/connectomemapper3?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@sebastientourbier) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@osorensen
Copy link
Member

@sebastientourbier can you please update us on how it is going addressing the points raised by the reviewers?

@osorensen
Copy link
Member

Here are the lines: https://github.com/connectomicslab/connectomemapper3/search?q=isbn&type=

@sebastientourbier
Copy link

@osorensen All isbn fields have been removed 👍

@osorensen
Copy link
Member

@editorialbot check references

@osorensen
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.3475969 is OK
- 10.1016/J.NEUROIMAGE.2011.08.056 is OK
- 10.1038/nn.4500 is OK
- 10.5281/zenodo.3571874 is OK
- 10.3389/fninf.2019.00001 is OK
- 10.1038/s41592-018-0235-4 is OK
- 10.1038/nn.4502 is OK
- 10.1371/journal.pone.0048121 is OK
- 10.3389/conf.fninf.2013.09.00042 is OK
- 10.1016/j.neuroimage.2015.04.042 is OK
- 10.1101/188706 is OK
- 10.1016/j.neuroimage.2006.01.021 is OK
- 10.1016/j.neuroimage.2015.02.065 is OK
- 10.1371/journal.pcbi.1005209 is OK
- 10.1146/annurev-biodatasci-072018-021237 is OK
- 10.3389/fninf.2014.00008 is OK
- 10.1162/netn_e_00052 is OK
- 10.1016/j.neuroimage.2012.01.021 is OK
- 10.5075/epfl-thesis-3230 is OK
- 10.1016/J.NEUROIMAGE.2011.09.015 is OK
- 10.1016/j.clinph.2020.09.018 is OK
- 10.1038/sdata.2018.270 is OK
- 10.1016/j.jneumeth.2011.09.031 is OK
- 10.3389/fnins.2013.00267 is OK
- 10.1016/j.neuroimage.2019.116137 is OK
- 10.3389/fninf.2011.00013 is OK
- 10.1038/s41592-021-01185-5 is OK
- 10.5281/ZENODO.3712762 is OK
- 10.1371/journal.pone.0177459 is OK
- 10.21105/joss.01294 is OK
- 10.1038/sdata.2016.44 is OK
- 10.1371/journal.pcbi.0010042 is OK
- 10.1016/j.clinph.2019.09.006 is OK
- 10.1038/nn.4550 is OK
- 10.1016/j.nicl.2020.102336 is OK
- 10.1016/j.neuroimage.2020.117137 is OK
- 10.1162/netn_a_00147 is OK
- 10.1002/hbm.25365 is OK
- 10.1016/j.neuroimage.2021.118611 is OK
- 10.1162/netn_a_00218 is OK
- 10.18112/openneuro.ds003505.v1.1.1 is OK
- 10.1038/s41597-021-01116-1 is OK
- 10.1016/j.clinph.2021.10.008 is OK
- 10.1016/j.neuroimage.2009.10.003 is OK
- 10.12688/f1000research.20887.3 is OK
- 10.1101/gr.1239303 is OK
- 10.1101/2022.01.31.478189 is OK
- 10.1162/netn_a_00114 is OK
- 10.1073/PNAS.1922248117 is OK
- 10.1016/j.media.2007.06.004 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@osorensen
Copy link
Member

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.3475969 is OK
- 10.1016/J.NEUROIMAGE.2011.08.056 is OK
- 10.1038/nn.4500 is OK
- 10.5281/zenodo.3571874 is OK
- 10.3389/fninf.2019.00001 is OK
- 10.1038/s41592-018-0235-4 is OK
- 10.1038/nn.4502 is OK
- 10.1371/journal.pone.0048121 is OK
- 10.3389/conf.fninf.2013.09.00042 is OK
- 10.1016/j.neuroimage.2015.04.042 is OK
- 10.1101/188706 is OK
- 10.1016/j.neuroimage.2006.01.021 is OK
- 10.1016/j.neuroimage.2015.02.065 is OK
- 10.1371/journal.pcbi.1005209 is OK
- 10.1146/annurev-biodatasci-072018-021237 is OK
- 10.3389/fninf.2014.00008 is OK
- 10.1162/netn_e_00052 is OK
- 10.1016/j.neuroimage.2012.01.021 is OK
- 10.5075/epfl-thesis-3230 is OK
- 10.1016/J.NEUROIMAGE.2011.09.015 is OK
- 10.1016/j.clinph.2020.09.018 is OK
- 10.1038/sdata.2018.270 is OK
- 10.1016/j.jneumeth.2011.09.031 is OK
- 10.3389/fnins.2013.00267 is OK
- 10.1016/j.neuroimage.2019.116137 is OK
- 10.3389/fninf.2011.00013 is OK
- 10.1038/s41592-021-01185-5 is OK
- 10.5281/ZENODO.3712762 is OK
- 10.1371/journal.pone.0177459 is OK
- 10.21105/joss.01294 is OK
- 10.1038/sdata.2016.44 is OK
- 10.1371/journal.pcbi.0010042 is OK
- 10.1016/j.clinph.2019.09.006 is OK
- 10.1038/nn.4550 is OK
- 10.1016/j.nicl.2020.102336 is OK
- 10.1016/j.neuroimage.2020.117137 is OK
- 10.1162/netn_a_00147 is OK
- 10.1002/hbm.25365 is OK
- 10.1016/j.neuroimage.2021.118611 is OK
- 10.1162/netn_a_00218 is OK
- 10.18112/openneuro.ds003505.v1.1.1 is OK
- 10.1038/s41597-021-01116-1 is OK
- 10.1016/j.clinph.2021.10.008 is OK
- 10.1016/j.neuroimage.2009.10.003 is OK
- 10.12688/f1000research.20887.3 is OK
- 10.1101/gr.1239303 is OK
- 10.1101/2022.01.31.478189 is OK
- 10.1162/netn_a_00114 is OK
- 10.1073/PNAS.1922248117 is OK
- 10.1016/j.media.2007.06.004 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉 openjournals/joss-papers#3299

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3299, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Jun 24, 2022
@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Jun 25, 2022

@sebastientourbier

  • I checked the archive meta-data and all looks good. 👍
  • I checked the version tag for the review and archive and verified they match 👍
  • I proofread the paper and have the following comment:
  • Introduce Magnetic Resonance Imaging (MRI) in the summary where MRI is first used.

@sebastientourbier
Copy link

Dear @Kevin-Mattheus-Moerman,

Thank you very much.

I just took care to introduce MRI the very first time it is used in the paper. I also took care of defining BIDS in the summary too. Finally, I noticed that I was redefining CMP3 acronym multiple times and this has been fixed. The changes can be viewed in connectomicslab/connectomemapper3#196.

Let me know if you need anything else.
Best

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.04248 joss-papers#3312
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04248
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Jun 27, 2022
@Kevin-Mattheus-Moerman
Copy link
Member

@sebastientourbier congratulations on your JOSS publication!

@osorensen thanks for editing this one!

And special thanks to @adbartni and @jsheunis for your review efforts!! 🎉

@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04248/status.svg)](https://doi.org/10.21105/joss.04248)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04248">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04248/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04248/status.svg
   :target: https://doi.org/10.21105/joss.04248

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@sebastientourbier
Copy link

This is a really great 🎉
Thank you very much all for the time you invested in the reviewing/editing process. It really helped in improving the robustness and the documentation of CMP3, as well as the quality of the paper. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Dockerfile published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Shell
Projects
None yet
Development

No branches or pull requests

6 participants