Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE / COPYRIGHT file content #154

Closed
jsheunis opened this issue Apr 7, 2022 · 2 comments · Fixed by #163
Closed

LICENSE / COPYRIGHT file content #154

jsheunis opened this issue Apr 7, 2022 · 2 comments · Fixed by #163

Comments

@jsheunis
Copy link
Contributor

jsheunis commented Apr 7, 2022

Issue related to JOSS review: openjournals/joss-reviews#4248

Hi @sebastientourbier

Based on the JOSS review checklist and review criteria, the repo has to contain a LICENSE or COPYING file with content that is OSI approved. At first glance, your COPYRIGHT file doesn't seem to conform to these criteria, even though it is clear in its intent. I am not sure how closely the JOSS editors expect the criteria to be followed, so perhaps it's a good idea to check with them. Something else worth checking is whether putting restrictions on the use of the code, i.e.

THIS SOFTWARE IS FOR RESEARCH PURPOSES ONLY AND SHALL NOT BE USED FOR
ANY CLINICAL USE.

is actually aligned with OSI approved licenses (I am not sure about this.)

@jsheunis
Copy link
Contributor Author

jsheunis commented Apr 7, 2022

And I see individual modules mention:

This software is distributed under the open-source license Modified BSD.

although Modified BSD isn't mentioned in the COPYRIGHT file.

@jsheunis
Copy link
Contributor Author

jsheunis commented Apr 7, 2022

And the docs license has the heading BSD 3-clause license. So I think it would be useful to make the different entries referring to license/copyright as consistent as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant