Fix decimal formatting for oh-stepper #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jgeorgi <[email protected]>
florian-h05
approved these changes
Sep 25, 2023
florian-h05
pushed a commit
that referenced
this pull request
Sep 25, 2023
Fixes #2089. Possibly regression from #1875. Stepper formatValue was calculating displayed number of decimals from the value of the step property, not it's length. Signed-off-by: Justin Georgi <[email protected]> (cherry picked from commit 0cc4f27)
florian-h05
added
the
patch
|
@JustinGeorgi FYI I have backported this to 4.0.x, so it will be published with the next patch release. |
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 4, 2023
Regression from openhab#2090. Fixes `Uncaught TypeError: Cannot read properties of undefined (reading 'length')` being thrown if the step property is an integer value, e.g. 1 or 1.0. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 4, 2023
Regression from openhab#2090. Fixes `Uncaught TypeError: Cannot read properties of undefined (reading 'length')` being thrown if the step property is an integer value, e.g. 1 or 1.0. Signed-off-by: Florian Hotze <[email protected]>
kaikreuzer
pushed a commit
that referenced
this pull request
Oct 8, 2023
Regression from #2090. Fixes `Uncaught TypeError: Cannot read properties of undefined (reading 'length')` being thrown if the step property is an integer value, e.g. 1 or 1.0. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
that referenced
this pull request
Oct 8, 2023
Regression from #2090. Fixes `Uncaught TypeError: Cannot read properties of undefined (reading 'length')` being thrown if the step property is an integer value, e.g. 1 or 1.0. Signed-off-by: Florian Hotze <[email protected]> (cherry picked from commit d4d7bea)
kaikreuzer
pushed a commit
that referenced
this pull request
Nov 2, 2023
…control Item with NaN state (#2137) Regression from #2090. Reported on the community, see https://community.openhab.org/t/openhab-4-1-0-m2-oh-stepper-not-working-properly/150372?u=florian-h05. --------- Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
that referenced
this pull request
Nov 2, 2023
…control Item with NaN state (#2137) Regression from #2090. Reported on the community, see https://community.openhab.org/t/openhab-4-1-0-m2-oh-stepper-not-working-properly/150372?u=florian-h05. --------- Signed-off-by: Florian Hotze <[email protected]> (cherry picked from commit 060c14e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2089.
Possibly regression from #1875.
Stepper formatValue was calculating displayed number of decimals from the value of the step property, not it's length.
Signed-off-by: Justin Georgi [email protected]