Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oh-stepper-item ignoring 2+ decimal places #2089

Closed
mstormi opened this issue Sep 24, 2023 · 1 comment · Fixed by #2090
Closed

oh-stepper-item ignoring 2+ decimal places #2089

mstormi opened this issue Sep 24, 2023 · 1 comment · Fixed by #2090
Labels
bug Something isn't working main ui Main UI

Comments

@mstormi
Copy link

mstormi commented Sep 24, 2023

The stepper widget only shows one decimal place at most.
You can define scale: 0.01 and it's honored the value changes but you have to click 10 times "+" before the shown value is changed.

The value should be shown with as many decimal places as the display pattern defined in item metadata.
@mstormi mstormi added bug Something isn't working main ui Main UI labels Sep 24, 2023
@JustinGeorgi
Copy link
Contributor

Oh, I noted this a while back. It's an easy fix, it just slipped my mind and I never submitted it.

@JustinGeorgi JustinGeorgi mentioned this issue Sep 24, 2023
Merged
florian-h05 pushed a commit that referenced this issue Sep 25, 2023
@JustinGeorgi
Fix decimal formatting for oh-stepper (#2090)
0cc4f27 
Fixes #2089.
Possibly regression from #1875.

Stepper formatValue was calculating displayed number of decimals from the value of the step property, not it's length.

Signed-off-by: Justin Georgi <[email protected]>
florian-h05 pushed a commit that referenced this issue Sep 25, 2023
@JustinGeorgi @florian-h05
Fix decimal formatting for oh-stepper (#2090)
73333ec 
Fixes #2089.
Possibly regression from #1875.

Stepper formatValue was calculating displayed number of decimals from the value of the step property, not it's length.

Signed-off-by: Justin Georgi <[email protected]>
(cherry picked from commit 0cc4f27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix decimal formatting for oh-stepper JustinGeorgi/openhab-webui
2 participants
@mstormi @JustinGeorgi