oh-stepper: Fix NaN shown for Item state with unit & Fix unable to control Item with NaN state
#2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <[email protected]>
Job #1209: Bundle Size — 15.79MiB (+0.2%).Warning Bundle contains 16 duplicate packages – View duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1209 report View florian-h05:oh-stepper-nan branch activity |
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
changed the title
oh-stepper: Fix NaN shown for Item state containing unit and unable to control Item when NaN is displayed
florian-h05
changed the title
oh-stepper: Fix NaN shown for Item state containing unit and unable to control Item when NaN is displayedoh-stepper: Fix NaN shown for Item state containing unit and unable to control Item when NaN is shown
florian-h05
changed the title
oh-stepper: Fix NaN shown for Item state containing unit and unable to control Item when NaN is shownoh-stepper: Fix NaN shown for Item state containing unit & Fix unable to control Item when NaN is shown
florian-h05
changed the title
oh-stepper: Fix NaN shown for Item state containing unit & Fix unable to control Item when NaN is shownoh-stepper: Fix NaN shown for Item state with unit & Fix unable to control Item when NaN is shown
florian-h05
changed the title
oh-stepper: Fix NaN shown for Item state with unit & Fix unable to control Item when NaN is shownoh-stepper: Fix NaN shown for Item state with unit & Fix unable to control Item with NaN state
|
This fix worked for me. I had a number with units that was not being handled correctly in the stepper card. https://community.openhab.org/t/openhab-4-1-0-m2-oh-stepper-not-working-properly/150372/4 Thanks for the quick action. |
|
I also applied the fix provided here |
|
Works for me 👍 |
kaikreuzer
approved these changes
Nov 2, 2023
florian-h05
added a commit
that referenced
this pull request
Nov 2, 2023
…control Item with NaN state (#2137) Regression from #2090. Reported on the community, see https://community.openhab.org/t/openhab-4-1-0-m2-oh-stepper-not-working-properly/150372?u=florian-h05. --------- Signed-off-by: Florian Hotze <[email protected]> (cherry picked from commit 060c14e)
florian-h05
added
the
patch
|
@kaikreuzer I have just cherry-picked this. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #2090.
Reported on the community, see https://community.openhab.org/t/openhab-4-1-0-m2-oh-stepper-not-working-properly/150372?u=florian-h05.