Upgrade to Karaf 4.4.3

[wborn]

• Rework Servlets to use Http Whiteboard annotations in favor of proprietary org.openhab.core.io.http.servlet classes

---

Depends on openhab/openhab-core#3252

To do:

• Rebase and fix merge conflicts (most notably Use a custom servlet for serving files to support caching of files #1521)
• Upgrade to the latest greatest Karaf 4.4 version
• Check, fix add-on servlets that no longer work
• Fix missing content type headers causing openHAB SVG logo not showing in main UI
• Remove or fix UIErrorPageServlet

Fixes #1172

[J-N-K]

There is one issue with MainUI, the openHAB logo in the upper left corner is not properly loading. I couldn't figure out why. BasicUI is fine as far as I can see.

I can't check the full build because as mentioned in #1353 it's not possible to build HaBOT on Apple Silicon.

[J-N-K]

Did you get the openHAB logo to load?

[wborn]

Did you get the openHAB logo to load?

it's still an issue so I'll add it to the todos.

[J-N-K]

Maybe @digitaldan can help us here?

[digitaldan]

Did you get the openHAB logo to load?

Can someone post a screenshot from the chrome developer/debug window of the network request (including headers and response) failing ?

[J-N-K]

Missing logo:

Element:

HTTP request:

HTTP response:

[digitaldan]

Hmm, there's no content type on that like content-type: image/svg+xml, but the returned length looks right. I'm assuming that content type would be handled internally by Jetty as we don't do any custom mapping there. Do you know if SVGs are working else where ?

[digitaldan]

Actually, that content length does not look right, way to big compared to my own system:

Can you curl that URL and see what the server is actually returning ?

[digitaldan]

Actually, never mind, it does look the right size, i forgot i was going through my Caddy server which was doing some compression, here's the image directly to my OH, although it does contain a content-type which may be the missing element here.

[J-N-K]

Yes, two headers are missing:

Content-Type: image/svg+xml
Vary: Accept-Encoding

Requesting the file directly shows the correct file.

[J-N-K]

I found that the reason for the missing content-type is that the MIME-type map in the ContextHandler is empty. I didn’t check if that was the case before.

[wborn]

The content type is cached as well and based on the Resource.toString value. 🙃

See:

https://github.com/eclipse/jetty.project/blob/da9a0b30691a45daf90a9f17b5defa2f1434f882/jetty-server/src/main/java/org/eclipse/jetty/server/CachedContentFactory.java#L411

[J-N-K]

And that works? I was already there with the debugger, but _mimeTypes has an empty map in my system.

[wborn]

It looks empty but if it is empty it falls back to use __dftMimeMap which does not show in your debugger if you hover over it. 🙂

[wborn]

@openhab/webui-maintainers can you review this PR?
It's required for successful builds now that openhab/openhab-core#3252 got merged.