Allow building most bundles on Apple Silicon processors and upgrade tooling. #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to figure out if it's HaBOT related |
This mainly upgrades NodeJS from 12.16.1 to 16.13.0. The only bundle that still can't be built is HaBOT because there are too many "old" dependencies that I am not able to update due to lack of knowledge. Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
|
Pretty obvious. Once I upgrade the HABot tooling, the build hangs forever. |
|
@ghys How so we proceed here? Shall I remove the upgrade for habot? As I said before, unfortunately I don‘t have enough knowledge to upgrade the dependencies that block the beide upgrade. |
|
Right, let's abandon the harmonization of versions and let's keep the HABot build on node v12 then, at least for now. |
|
Thanks! LGTM. |
|
Sure. |
Signed-off-by: Jan N. Klug <[email protected]>
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up to #1215 (can't be re-opened for unknown reasons).