-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP code 200 returned for invalid pages #1172
Comments
This is not an openhab-core issue but an openhab-webui Main UI issue. It uses routes.js to determine what to show. It routes to not-found.vue when no route matches. You can also test it by uninstalling the Main UI:
Then you get a 404 not found for that URL. 😉 |
This was indeed changed in #964 and that's an example of a "side effect" I was warning about. |
Can you transfer this issue to the webui repo @kaikreuzer? |
* Rework Servlets to use Http Whiteboard annotations in favor of proprietary `org.openhab.core.io.http.servlet` classes Depends on openhab/openhab-core#3252 Fixes #1172 Signed-off-by: Wouter Born <[email protected]>
When connection to the openHAB server and try to access to notifications api (it's only on cloud, so this should produce an error), I get http code 200:
This causes the Android app to recognize the server as cloud instance and tries to parse the response as json, but it's html. IMO the server should respond with 404 for not found subpages.
Browser for reference:
Android issue: openhab/openhab-android#2662
The text was updated successfully, but these errors were encountered: