Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diamond operator and remove redundant type arguments #16249

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 9, 2024

Simplifies the code by using the diamond operator and removing redundant type arguments.

Copy link
Contributor

@ne0h ne0h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@david-pace david-pace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for boschshc

Copy link
Contributor

@ccutrer ccutrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for bondhome, mqtt, and homekit

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for simplifying the code. LGTM.

Copy link
Contributor

@hmerk hmerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit a2868bb into openhab:main Jan 9, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Jan 9, 2024
@wborn wborn deleted the use-diamond-operator branch January 10, 2024 09:02
Copy link
Contributor

@dougculnane dougculnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Contributor

@bern77 bern77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for HeliosEasycontrols

theater added a commit to theater/openhab-addons that referenced this pull request Jan 14, 2024
* Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes
* Fix the headers for the new / refactored / moved classes for 2024

Signed-off-by: Konstantin Polihronov <[email protected]>
@carlee82

This comment was marked as off-topic.

@lsiepel
Copy link
Contributor

lsiepel commented Jan 18, 2024

No developer, just a user question. I own the Fronius Smart Meter IP, which is not connected by modbus cable to the inverter. It has an own IP address. Any chance the addon can connect to this new IP Smart Meter. The values it provides are the same as the standard model connected by modbus cable

Please create a separate issue.

Copy link

@Wolfgang1966 Wolfgang1966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for awattar. Thank you

Copy link
Contributor

@mvalla mvalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for openwebnet

andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
theater added a commit to theater/openhab-addons that referenced this pull request Feb 12, 2024
* Initial rearrangement of classes and cloud response in test
* Refactoring of packages and initial version of retrieval of data
* Test for parsed raw data
* Move the enums for status and type to the root model package
* Another package refactoring + basic handler functionality
* Handler works now, most build warnings removed
* Add initial exception handling during the update
* Small code style fixes and channel for inverter status
* Add all defined channels from the XML in the handler
* Add translations of the status and support for zones and I18N
* Update readme
* Fix error handling in the Cloud connection handler
* Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes
* Fix the headers for the new / refactored / moved classes for 2024

Signed-off-by: Konstantin Polihronov <[email protected]>
theater added a commit to theater/openhab-addons that referenced this pull request Feb 12, 2024
* Initial rearrangement of classes and cloud response in test
* Refactoring of packages and initial version of retrieval of data
* Test for parsed raw data
* Move the enums for status and type to the root model package
* Another package refactoring + basic handler functionality
* Handler works now, most build warnings removed
* Add initial exception handling during the update
* Small code style fixes and channel for inverter status
* Add all defined channels from the XML in the handler
* Add translations of the status and support for zones and I18N
* Update readme
* Fix error handling in the Cloud connection handler
* Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes
* Fix the headers for the new / refactored / moved classes for 2024

Signed-off-by: Konstantin Polihronov <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.