-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use diamond operator and remove redundant type arguments #16249
Conversation
Signed-off-by: Wouter Born <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for boschshc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for bondhome, mqtt, and homekit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for simplifying the code. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for HeliosEasycontrols
* Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes * Fix the headers for the new / refactored / moved classes for 2024 Signed-off-by: Konstantin Polihronov <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Please create a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for awattar. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for openwebnet
Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
* Initial rearrangement of classes and cloud response in test * Refactoring of packages and initial version of retrieval of data * Test for parsed raw data * Move the enums for status and type to the root model package * Another package refactoring + basic handler functionality * Handler works now, most build warnings removed * Add initial exception handling during the update * Small code style fixes and channel for inverter status * Add all defined channels from the XML in the handler * Add translations of the status and support for zones and I18N * Update readme * Fix error handling in the Cloud connection handler * Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes * Fix the headers for the new / refactored / moved classes for 2024 Signed-off-by: Konstantin Polihronov <[email protected]>
* Initial rearrangement of classes and cloud response in test * Refactoring of packages and initial version of retrieval of data * Test for parsed raw data * Move the enums for status and type to the root model package * Another package refactoring + basic handler functionality * Handler works now, most build warnings removed * Add initial exception handling during the update * Small code style fixes and channel for inverter status * Add all defined channels from the XML in the handler * Add translations of the status and support for zones and I18N * Update readme * Fix error handling in the Cloud connection handler * Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes * Fix the headers for the new / refactored / moved classes for 2024 Signed-off-by: Konstantin Polihronov <[email protected]>
Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Signed-off-by: Wouter Born <[email protected]>
Simplifies the code by using the diamond operator and removing redundant type arguments.