-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freeathome] Initial contribution #13703
Conversation
a5aaa19
to
5d28009
Compare
...ab.binding.freeathomesystem/src/main/resources/OH-INF/i18n/freeathomesystem_xx_XX.properties
Outdated
Show resolved
Hide resolved
Hello @lsiepel, The complete build is failing in other bindings as mine, however my branch is in synch with the main stream. I tried everything but I cannot solve the issue. could you give a hint what I shall fix or try |
There are some SAT issues that should be addressed. I understand that you excluded some addons to get the builds wortking, but please revert it. They seem to be unrelated as far as i can see. |
Ok I will have a look on it and revert the removal of 2 packages. |
I reverted the changes, the stream is in sync, however now the MercedesMe binding is not building. Static code analysis failure for the command "mvn clean install". (I checked only in local build) Do you have any idea, what to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building errors seem to be solved by other commits to the faulty addons. Now there are more SAT-details available, some need you attention: https://github.com/openhab/openhab-addons/suites/9452497308/artifacts/447382278
eI left a note about the readme regarding logging. There are some screenshots, don't think they should be added too,
If these are fixed, i think some more experienced reviewer can do another pass, Thank you!
2d3f73a
to
b06b789
Compare
Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Apply suggestions from code review Signed-off-by: Andras Uhrin <[email protected]>
....openhab.binding.freeathomesystem/src/main/resources/OH-INF/i18n/freeathomesystem.properties
Outdated
Show resolved
Hide resolved
Apply suggestions from code review * Minor changes in examples Signed-off-by: Andras Uhrin <[email protected]>
Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Everything is addressed, thank you! There are now a few compiler warnings and SAT findings left. You can take a look at target/code-analysis/report.html. I think they can be addressed easily, and this PR is then ready for being merged. |
Apply suggestions from code review Signed-off-by: Andras Uhrin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing this new binding and for enduring the long review process. 👍
Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website
Thank you from my side to be able to be part of this great community! |
@andrasU - seeing the logo in openhab/openhab-docs#2286 made me wonder: Do you think the binding should actually be named "free@home" rather than "free@home system"? I'm wondering is the binding id should be simplified to "freeathome". In that PR you also refer to it as "free@home binding". It's a bit late I'm asking myself and you this question, but this is probably the final chance to do something about it. |
Signed-off-by: Andras Uhrin <[email protected]>
@andrasU - gentle ping, did you see this question? If we decide to rename the binding, it would probably be best to do this before next milestone. |
@jlaur: You have completely right the name shall be "free@home". This is also the name as ABB and Busch-Jaeger referencing the smart home system. The name freeathomesystem was my work-title. |
All right, let's rename binding id to "freeathome" then.
Yes, you can branch out from latest main and create a new PR with the needed changes. As a minimum, the folder must be renamed, as well as everything referring to binding id "freeathomesystem" within. Search & replace might come in handy. There are also a few files outside the binding folder that must be updated, e.g. pom.xml and CODEOWNERS. |
Did this recently, so i created a PR directly. Only need to fix the pom. give me a second |
@lsiepel - thanks! Can you also update CODEOWNERS? @kaikreuzer - can you add @andrasU to the contributor team as he is now maintainer of the free@home binding? 🙂 |
Sure thing! Done. 😄 |
Signed-off-by: Andras Uhrin <[email protected]> Signed-off-by: Paul Smedley <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
This is the reworked initial contribution of the free@home binding, which is based on the official local API from ABB/Busch-Jäger
ABB/Busch-Jäger free@home binding for OpenHAB
This is a new binding for controlling free@home devices from ABB / Busch-Jaeger. I would like to provide this binding to the OpenHAB community to be able to bind the free@home devices through the official API.
This Binding makes possible to control the [free@home] devices through the free@home SysAP bridge.
The SysAP bridge is the only one device, which shall be added manually to the system.
The things can be detected on the openHAB dashboard
This binding is creating the thing's channels automatically based the free@home drives features.
The following gateway and devices are supported
Network Gateway / System Access Point
Supported Devices
Tests
The new features (also the old implementation) is verified by the community
openhAB communitiy of this binding
binaries
https://github.com/andrasU/openhab-addons/releases/tag/fh-v4.0.1