Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary semicolons #16214

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 5, 2024

This helps with stopping the proliferation of unnecessary semicolons.

This helps with stopping the proliferation of unnecessary semicolons.

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn requested review from a team, sibbi77, mgeramb and aurelio1 as code owners January 5, 2024 17:30
Copy link
Contributor

@theater theater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robnielsen
Copy link
Contributor

lgtm

Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 5, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 3415397 into openhab:main Jan 5, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Jan 5, 2024
@wborn wborn deleted the remove-unnecessary-semicolons branch January 5, 2024 22:57
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nanoleaf looks good to me

Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

theater added a commit to theater/openhab-addons that referenced this pull request Jan 14, 2024
* Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes
* Fix the headers for the new / refactored / moved classes for 2024

Signed-off-by: Konstantin Polihronov <[email protected]>
theater added a commit to theater/openhab-addons that referenced this pull request Feb 12, 2024
* Initial rearrangement of classes and cloud response in test
* Refactoring of packages and initial version of retrieval of data
* Test for parsed raw data
* Move the enums for status and type to the root model package
* Another package refactoring + basic handler functionality
* Handler works now, most build warnings removed
* Add initial exception handling during the update
* Small code style fixes and channel for inverter status
* Add all defined channels from the XML in the handler
* Add translations of the status and support for zones and I18N
* Update readme
* Fix error handling in the Cloud connection handler
* Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes
* Fix the headers for the new / refactored / moved classes for 2024

Signed-off-by: Konstantin Polihronov <[email protected]>
theater added a commit to theater/openhab-addons that referenced this pull request Feb 12, 2024
* Initial rearrangement of classes and cloud response in test
* Refactoring of packages and initial version of retrieval of data
* Test for parsed raw data
* Move the enums for status and type to the root model package
* Another package refactoring + basic handler functionality
* Handler works now, most build warnings removed
* Add initial exception handling during the update
* Small code style fixes and channel for inverter status
* Add all defined channels from the XML in the handler
* Add translations of the status and support for zones and I18N
* Update readme
* Fix error handling in the Cloud connection handler
* Manual fixes openhab#16249 and openhab#16214 due to refactored packages and classes
* Fix the headers for the new / refactored / moved classes for 2024

Signed-off-by: Konstantin Polihronov <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
This helps with stopping the proliferation of unnecessary semicolons.

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
This helps with stopping the proliferation of unnecessary semicolons.

Signed-off-by: Wouter Born <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants