This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
informant: display I/O stats #11523
Merged
informant: display I/O stats #11523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: fix compilation warnings (#11522)
ordian
added
A0-pleasereview 🤓
ordian
commented
Feb 26, 2020
| @@ -234,7 +234,7 @@ impl<K: Kind, C> VerificationQueue<K, C> { | |||
| let number_of_threads = if scale_verifiers { | |||
| max_verifiers | |||
| } else { | |||
| cmp::min(default_amount, max_verifiers) | |||
| default_amount | |||
There was a problem hiding this comment.
this is an unrelated change, sorry
Let's go with this for the time being and see how useful it is. It would be nice to ponder a more general logging overhaul to add more flexibility but this is not the PR for that. |
* master: Code cleanup in the sync module (#11552) initial cleanup (#11542) Warn if genesis constructor revert (#11550) ethcore: cleanup after #11531 (#11546) license update (#11543) Less cloning when importing blocks (#11531) Github Actions (#11528) Fix Alpine Dockerfile (#11538) Remove AuxiliaryData/AuxiliaryRequest (#11533) [journaldb]: cleanup (#11534) Remove references to parity-ethereum (#11525) Drop IPFS support (#11532) chain-supplier: fix warning reporting for GetNodeData request (#11530) Faster kill_garbage (#11514) [EngineSigner]: don't sign message with only zeroes (#11524)
niklasad1
reviewed
Mar 10, 2020
ordian
commented
Mar 10, 2020
I think the general consensus is that maintaining multiple levels of caches is a bad idea and we should delegate caching and reuse it from the low-level db, like rocksdb and fs cache.
Not all stats are implemented for kvdb-rocksdb |
niklasad1
reviewed
Mar 10, 2020
dvdplm
approved these changes
Mar 10, 2020
niklasad1
approved these changes
Mar 10, 2020
Co-Authored-By: David <[email protected]>
ordian
added a commit
that referenced
this pull request
Mar 24, 2020
* master: informant: display I/O stats (#11523) [devp2p discovery]: remove `deprecated_echo_hash` (#11564) [secretstore] create db_version file when database doesn't exist (#11570) Remove Parity's Security Policy (#11565) ethcore/res: enable ecip-1088 phoenix upgrade for kotti and mordor testnets (#11529) Misc docs and renames …and one less clone (#11556) [secretstore]: don't sign message with only zeroes (#11561) [devp2p discovery]: cleanup (#11547) Code cleanup in the sync module (#11552) initial cleanup (#11542) Warn if genesis constructor revert (#11550)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what is the best way to display the logs hence the draft: