This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove AuxiliaryData/AuxiliaryRequest #11533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove bytes member from AuxiliaryData
dvdplm
changed the title
tomusdrw
approved these changes
Mar 3, 2020
Yes, since #6591 (I guess it depends what you mean by beginning 😄) |
ordian
approved these changes
Mar 3, 2020
ordian
added
A8-looksgood 🦄
niklasad1
reviewed
Mar 3, 2020
dvdplm
added a commit
that referenced
this pull request
Mar 3, 2020
ordian
added a commit
that referenced
this pull request
Mar 6, 2020
ordian
added a commit
that referenced
this pull request
Mar 10, 2020
* master: Code cleanup in the sync module (#11552) initial cleanup (#11542) Warn if genesis constructor revert (#11550) ethcore: cleanup after #11531 (#11546) license update (#11543) Less cloning when importing blocks (#11531) Github Actions (#11528) Fix Alpine Dockerfile (#11538) Remove AuxiliaryData/AuxiliaryRequest (#11533) [journaldb]: cleanup (#11534) Remove references to parity-ethereum (#11525) Drop IPFS support (#11532) chain-supplier: fix warning reporting for GetNodeData request (#11530) Faster kill_garbage (#11514) [EngineSigner]: don't sign message with only zeroes (#11524)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only
Enginethat usesAuxiliaryDataisAuthorityRoundand it only usesReceipt. This PR removes bothAuxiliaryDataandAuxiliaryRequesttypes and changes theEngineasndValidatorSettraits to use justReceipt.I am a little worried that I have misunderstood the implications of this, in particular when it comes to the Light client, so careful review of that code would be much appreciated.