fix: AA-1058: Bust cache when Schedules are updated #117
Conversation
Dillon-Dumesnil
force-pushed
the
ddumesnil/update-transformer-aa-1058
branch
from
2e44ba2
to
7babf84
Compare
Dillon-Dumesnil
force-pushed
the
ddumesnil/update-transformer-aa-1058
branch
4 times, most recently
from
0377738
to
f32dbe2
Compare
edx_when/field_data.py
Outdated
| if Schedule: | ||
| try: | ||
| schedule = Schedule.objects.get( | ||
| enrollment__user=self.user, enrollment__course__id=usage_info.course_key |
There was a problem hiding this comment.
OK, so this is basically manually doing the needs_schedule flow inside get_dates_for_course, but bringing it outside, so that the schedule can be part of the cache key?
Would another solution be to look up the schedule inside get_dates if needs_schedule is true and then add it to the cache key (rather than making the cache key before looking up the schedule), so that callers don't have to work around this quirk?
There was a problem hiding this comment.
Dumb question, How does this bust the cache? Just trying to understand what's happening here.
There was a problem hiding this comment.
@cdeery Not a dumb question at all! There is a lot of institutional knowledge that is working behind the scenes here.
So the issue has to do with Personalized Learning Schedules for our self-paced users where we base their due dates off of their Schedule start date. Verified learners are able to reset their due dates if they fall behind which will update their Schedule start date to today's date and thus push all of their deadlines down the road giving them time to work on the course again. The issue here is that after learners reset their due dates, edx-when was still finding their old cached dates and so when the page reloaded, none of their due dates were reset for them despite the backend/database knowing the start date changed. This busts the cache because, if provided, the schedule start date becomes part of the cache key. So now when a learner resets their due dates and we fetch their schedule, it will result in a new cache key and us returning the correct dates.
I hope that clears it up, but if not, please follow-up!
|
Update: Going with MT's idea to move it down a level so other people/us don't hit this again in the future. Will attempt a test! |
Dillon-Dumesnil
force-pushed
the
ddumesnil/update-transformer-aa-1058
branch
4 times, most recently
from
c80afb0
to
14d42b4
Compare
We had a bug reported where learners would reset their due dates for their Personalized Learner Schedule, but the dates wouldn't update. This was a result of the cache key not changing, so this fix adds in the learner's schedule to the transformer.
Dillon-Dumesnil
force-pushed
the
ddumesnil/update-transformer-aa-1058
branch
from
14d42b4
to
2566443
Compare
Description: We had a bug reported where learners would reset their due dates
for their Personalized Learner Schedule, but the dates wouldn't
update. This was a result of the cache key not changing, so this
fix adds in the learner's schedule to the transformer.
JIRA: https://openedx.atlassian.net/browse/AA-1058
Merge checklist:
Post merge:
finished.