chore: AA-1058: Update edx-when version #29074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's being moved to the frontend, to better control when it's emitted (we want to only emit it if the voucher has not yet been claimed, which the frontend will ask ecommerce about). AA-1012
Add codejail service settings (endpoint and feature flag). Add conditional to allow running codejail using a REST API service when flag is enabled.
Address recommendations and fixes discussed in PR. Use similar structure to notes app. Fix errors detected in tests.
Address fixes recommended by @timmc-edx.
Address @felipemonotoya recommendations related to add versioning to safe_exec_remote functions.
nltk 3.6.3 drops support for python 3.5.
The lti user gets authenticated and logged in as a part of the LTI View Post. This results in the request user changing during the request. We mark it here so that it does not produce a false alarm in our SafeSessions middleware.
Optionally run Codejail in a external service using REST API.
…n_lti_post fix: Mark user change as expected in LTIToolLaunchView.post
…dleware (#29028) * feat: only log requests that fail user verification in SafeSessionMiddleware ARCHBOM-1923
The notices app is a plugin to edx-platform that needs to be tracked correctly for ownership.
fix: Decorate celery task to set code owner attribute.
fix: Add the notices to plugin mapping.
[MICROBA-1536]
It might not be master! (cherry picked from commit fc894e1)
* fix(program-portals): prevent resume course links from 404ing From time to time course teams will delete a problem in an active course. When this happens and that particular problem is the last completed subsection for a learner, some naive attempts to provide a "continue course" that takes the learner back to where they left off may result in 404s. This checks whether a learner would be able to access the block returned from completion data before we try to create a link to that part of the course structure to hand to that learner. It's used on the Master's program learner portal pages. JIRA:EDUCATOR-5313 Co-authored-by: Zach Hancock <[email protected]>
Since we may get user changes during registration, we mark it as expected so our Safe Session protection won't be triggered.
Since we may get a user change during access token login, we mark it as expected so our Safe Session protection won't be triggered.
…tic template library (#29052) TNL-8884. This change would fix the issue where the undeleting a user results in 500. This is a change needed after the django version is upgraded to django 3.2 Co-authored-by: Simon Chen <[email protected]>
Exempt multiple safe session user mismatches
* feat: [AA-906] Number of days Goal setting back end updates added number_of_days_goals_enabled flag to course_goals * feat: [AA-906] renamed number of days goal to WeeklyLearningGoal * feat: [AA-906] fix unit test * feat: [AA-906] fix unit test cleanup
feat: Add support for course dashboard redirect for notices app
This reverts commit 3611a8c.
Revert "feat: Add support for course dashboard redirect for notices app"
[MICROBA-1520] - Update course dashboard to check its context for unack'd notices from the notices app. If so, redirect the learner to the first unack'd notice. (reintroduces earlier changes that were reverted)
…29057) This has the side effect of requiring creation of a `studio_worker` service account, since the `create_dot_application` command requires a user arg, but this better matches other IDAs.
feat: Add support for course dashboard redirect for notices app
…29054) Commit modifies safe session middleware to return an 401 in case of authentication failure and lack of 'text/html' in Accept header. Previously, the middleware would always redirect to login in case of auth failure, but this was deemed inappropriate for any requests that are not top-level page navigation requests(we check this by seeming if 'text/html' is precent in Accept header) Co-authored-by: Robert Raposa <[email protected]>
feat: leave IDV out of proctoring requirements mail if honorcode
made changes to pages template refactored method to handle reordering of static tabs refactored test for the refactored method added link to the pages and resources MFE on the updated page
The learning MFE paths include /course/{course_id} which doesn't match /courses/{course_id} which is what the regex expects. This causes issues with the Wiki when when accessed from the learning MFE doesn't detect that course it's related to in the middleware.
fix: drop segment call for streak discount
|
jenkins run all |
Dillon-Dumesnil
force-pushed
the
ddumesnil/update-edx-when-version-aa-1058-maple
branch
from
f7a23ca
to
1895f4e
Compare
Dillon-Dumesnil
deleted the
ddumesnil/update-edx-when-version-aa-1058-maple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openedx/edx-when#117