Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt multiple safe session user mismatches #29053

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Oct 18, 2021

Description

Mark two user changes as expected so it doesn't trigger our Safe Session validation.

  1. Register
  2. Access Token Login

Supporting information

https://openedx.atlassian.net/browse/ARCHBOM-1813

Since we may get user changes during registration,
we mark it as expected so our Safe Session protection
won't be triggered.
Since we may get a user change during access token
login, we mark it as expected so our Safe Session
protection won't be triggered.
Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@robrap robrap merged commit e399fa4 into master Oct 18, 2021
@robrap robrap deleted the robrap/exempt-register-safe-session branch October 18, 2021 17:22
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants