-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: AA-1058: Update edx-when version #29073
chore: AA-1058: Update edx-when version #29073
Conversation
jenkins run all |
fa2f1f1
to
9558c35
Compare
Updates query counts for the additional query to look up the Schedule in edx-when
9558c35
to
78fbd28
Compare
Your PR has finished running tests. There were no failures. |
(ModuleStoreEnum.Type.mongo, 10, 164), | ||
(ModuleStoreEnum.Type.split, 4, 160), | ||
(ModuleStoreEnum.Type.mongo, 10, 227), | ||
(ModuleStoreEnum.Type.split, 4, 210), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These and the test_resolvers change below are big bumps. That seems worrying? At first blush, this test doesn't appear to be doing a similar thing 50 times, but I didn't chase its logic fully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dillon made https://openedx.atlassian.net/browse/AA-1081 to capture this issue as a follow-on item. In particular:
Although improving this is a great thing and we should do it/look into it, I do want to call out that the
_load_dates
function uses the read replica so hopefully even the introduction of these queries doesn't have an effect on production.
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
Related to openedx/edx-when#117