Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: AA-1058: Update edx-when version #29073

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

Dillon-Dumesnil
Copy link
Contributor

@Dillon-Dumesnil
Copy link
Contributor Author

jenkins run all

@Dillon-Dumesnil Dillon-Dumesnil force-pushed the ddumesnil/update-edx-when-version-aa-1058 branch from fa2f1f1 to 9558c35 Compare October 21, 2021 18:29
Updates query counts for the additional query to look up the Schedule
in edx-when
@Dillon-Dumesnil Dillon-Dumesnil force-pushed the ddumesnil/update-edx-when-version-aa-1058 branch from 9558c35 to 78fbd28 Compare October 22, 2021 13:36
@Dillon-Dumesnil Dillon-Dumesnil requested a review from a team October 22, 2021 13:36
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

Comment on lines -391 to +392
(ModuleStoreEnum.Type.mongo, 10, 164),
(ModuleStoreEnum.Type.split, 4, 160),
(ModuleStoreEnum.Type.mongo, 10, 227),
(ModuleStoreEnum.Type.split, 4, 210),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These and the test_resolvers change below are big bumps. That seems worrying? At first blush, this test doesn't appear to be doing a similar thing 50 times, but I didn't chase its logic fully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dillon made https://openedx.atlassian.net/browse/AA-1081 to capture this issue as a follow-on item. In particular:

Although improving this is a great thing and we should do it/look into it, I do want to call out that the _load_dates function uses the read replica so hopefully even the introduction of these queries doesn't have an effect on production.

@Dillon-Dumesnil Dillon-Dumesnil merged commit 4917c8d into master Oct 25, 2021
@Dillon-Dumesnil Dillon-Dumesnil deleted the ddumesnil/update-edx-when-version-aa-1058 branch October 25, 2021 13:06
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants