Preprocess assets as Django management command #5
Conversation
ghost
assigned 
|
@cpennington here's the real fix for that old assets.rake issue. I ended up putting the command inside the mitxmako app, but it'd be easy to move elsewhere if you'd prefer. |
| # just hardcode the asset filenames. | ||
| preprocess_with_mako("lms/static/sass/application.scss.mako") | ||
| desc "Preprocess all templatized static asset files" | ||
| task :preprocess, [:system, :env] do |t, args| |
There was a problem hiding this comment.
Rake passes all args down through the chain of commands...I hadn't known that. Pretty slick.
There was a problem hiding this comment.
And, as I found out, that's only if a task that depends on this one takes these args. Otherwise, the defaults are used.
|
@chrisndodge this is the real real fix for the assets.rake problem. If there's a good way to test it out with a real production env.json file, then let me know. |
|
Hmmm. Seems like you need to rebase? |
|
Ergh. I sent this in before Marco merged release back into master. Will do On Thursday, May 30, 2013, chrisndodge wrote:
Nate |
|
Okay, @chrisndodge @cpennington, rebased to master post-release merge. Should be good to review. |
|
OK, builds are failing, but it's not related to your work. Anyhow, PR looks OK otherwise codewise. I'll try deploying this to stage@edge for testing purposes. |
|
Sorry deploy is failing. Seems like it is trying to open up a log file in the wrong place. Typically the log is in /mnt/logs/|cms, lms, ....| Perhaps you can coordinate with @e0d or @jarv Here is the stack trace: 30531 09:43:33 ] : [stage-edge-edxapp-001.m.edx.org:22] out: (See full trace by running task with --trace) |
|
@chrisndodge when you ran on stage, did you pass in an environment or system? It defaults to lms and dev, which means it would use lms/envs/dev.py, but on staging/production servers we'd want to use lms/envs/aws.py. I think that would contribute to the error message you were seeing. |
|
👍 shipit |
|
@cpennington this is the fab command I used: fab tags:group=edxapp,env=edge_staging git:edx-platform=d3e2b87cd7466fed5e8c637aa826447b5d9cc450 |
|
Could it be that I write to stdout? On Friday, May 31, 2013, chrisndodge wrote:
Nate |
|
@chrisndodge any way for me to reproduce the error you're seeing? |
|
Hmmm. I don't have an idea off the top of my head. Can you use this script On Fri, May 31, 2013 at 5:53 PM, Nate Hardison [email protected]:
|
|
@jbau could you take a look at @chrisndodge's comments when you get a chance? This change is blocking some of the theming work that @caesar2164 and I are doing. |
|
@natehardison and I are on this. It seems like the write to stdout is a potential culprit. We're looking for workaround now. |
|
Okay, I think @jbau and I have figured out what was going on. The The fix is to rewrite the We also just found another bug, namely that I needed to add |
| @@ -319,6 +319,7 @@ | |||
| 'track', | |||
|
|
|||
| # For asset pipelining | |||
| 'mitxmako', | |||
There was a problem hiding this comment.
A deploy runs both lms:gather_assets:aws and cms:gather_assets:aws, so the CMS also needs access to the mitxmako app for the preprocess_assets management command.
|
Okay, @chrisndodge @cpennington, ready for review. @jbau verified that it deploys cleanly to our machines. |
|
@natehardison Ok, was able to get around the problem with my 'sysadmin' repo (reverted back a few commits) and I've been able to push your branch out to stage@edge. @cpennington do you want to do a final signoff on the code side of things? Otherwise I'm +1 |
|
Failing because of pep8 and pylint violations. Will rebase. @cpennington @ormsbee any thoughts on the code? In particular, thoughts on the |
|
@natehardison can we finish off this PR on Monday? Seems like Cale already +1'd it up above. |
|
I'll merge it today if that's okay. On Sunday, June 2, 2013, chrisndodge wrote:
Nate |
|
OK, I see we don't have a green checkmark on this PR. It's probably due to the fact Jenkins was broken late last week. Can you check in a small change (e.g. may a comment or a docstring) to kick off another build. Thanks. Then when you see a green check, you can do the merge. Then let me know when it's done and I'll try a deploy to staging to verify it. |
You can now specify an arbitrary URL to a browser compatible video file for the course intro video.
Allow arbitrary embed code for intro video, in addition to direct URL and YouTube video ID.
…orum changing "discussion" tab to say "Forum"
…OAuth to amplify-master * commit 'a5d34f8bc42adddf91feddf650d8fa654d65b63d': Change http to https in redirect_uri Change the variable name for key and secret change amplify oauth provider from fqa to prod Fix pylint errors and refine the code change amplify oauth class to fix the link and redirect_uri problems delete unused library import Change amplify provider's name and change auth urls to prod import amplify profider from edx third party lib instead of python lib Add amplify as third party auth provider for edX/Amplify SSO
Edunext utec/student account
removed correct/incorrect indicators
# This is the 1st commit message: ENT-385 change error msg for confirm email # This is the commit message #2: remove changed msgid from po files # This is the commit message #3: add name to AUTHORS file # This is the commit message #4: remove lastfailed file # This is the commit message #5: GradingPolicyChanged Signal Handler https://openedx.atlassian.net/browse/EDUCATOR-393 # This is the commit message #6: EDUCATOR-435 | Include enrollment status in in course and problem grade reports. # This is the commit message #7: Change visibility to access. EDUCATOR-396 # This is the commit message #8: LEARNER-923 Make Pattern Library support tabs transparent # This is the commit message #9: Conform to WCAG 2 AA contrast minimums for Google OAuth. Also apply variables for FB/Linkedin OAuth2 rather than leave color hashes hanging around. # This is the commit message #10: Updated auto_auth endpoint to always return JSON Defaulting to a plaintext response makes no sense for an endpoint that is intended to be used by machines for testing. The endpoint now returns JSON only unless a redirect action is triggered. # This is the commit message #1: Fix the activation email support link in the dashboard sidebar # This is the commit message #2: Mask grades on progress page according to "Show Correctness" setting. # This is the commit message #3: More celery logging # This is the commit message #4: Eventing for grading policy change # This is the commit message #5: More specific grace_course logging # This is the commit message #6: Add course overrides of waffle flags. # This is the commit message #7: Mark test as flaky, and remove flaky from a fixed test. EDUCATOR-511 # This is the commit message #8: Fix for LEARNER-859: Updating styling on the course updates page to more clearly differentiate between multiple updates. Specifically: - Updated styling on date in the top left corner - Added horizontal line between updates - Removed ability to toggle updates on and off - Cleaned up code to always show all updates:
…to-caliper-app move caliper config and processor from track app to caliper_track app
Updated the python-dateutil version for correct arrow installation Approved-by: Rafay Khan
Rather than directly invoke command-line Python (and Mako) from the
assets Rakefile, or call an external Python script, use a Django
management command to preprocess all asset template files.
An "asset template file" is defined as a static asset file with a
file extension indicating that it needs to be run through a template
engine prior to Sass/CoffeeScript compilation or packaging with other
assets. The preprocess_assets management command will look through
all of the files listed in the
STATICFILES_DIRS, preprocessing eachas needed. Preprocessing strips off the special template file
extension, creating a new file in the process.
Currently, the only variable accessible in an asset template file is
the
THEME_NAME, defined in the settings.