Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js that prevented single step OE problems (ie only self assessment) ... #2

Merged
merged 1 commit into from
May 31, 2013

Conversation

VikParuchuri
Copy link
Contributor

...from working

Prior to this, open response assessment problems with only a single "step" would not render the rubric properly or display a submission confirmation message. This fixes those issues.

Required ASAP for PH278, which wants to use an open response question with a single step.

@VikParuchuri
Copy link
Contributor Author

@brianhw Would you mind reviewing this?

@brianhw
Copy link
Contributor

brianhw commented May 31, 2013

It works! (Thanks for helping me to run this.)

VikParuchuri added a commit that referenced this pull request May 31, 2013
Fix js that prevented single step OE problems (ie only self assessment) ...
@VikParuchuri VikParuchuri merged commit 4a99784 into master May 31, 2013
valera-rozuvan pushed a commit that referenced this pull request Jul 1, 2013
valera-rozuvan pushed a commit that referenced this pull request Jul 3, 2013
valera-rozuvan pushed a commit that referenced this pull request Jul 4, 2013
valera-rozuvan pushed a commit that referenced this pull request Jul 9, 2013
valera-rozuvan pushed a commit that referenced this pull request Jul 18, 2013
Added missing file.~
Undid a mistake.
Copied Python tests from video_alpha1.
moves TestLogic to __init__.py
reorginizes xmodule logic tests
adds docstrings for poll tests
adds docstring for word cloud and conditional tests
adds docstrings for video alpha tests
adds videoalphafactory for tests, not finished
adds imports
Bug fixing.
fix video/videoalpha tests
Updated lettuce test. Now it is aware of the fact that Video and Video Alpha players have different base CSS classes.
Removed REFACTOR comments.
Turn off autoplay for Video Alpha in Studio.
Carry over fix for bug where in Firefox changing to speed 1.0 has no effect.
Carry over JavaScript Jasmine tests from jmclaus/videoalpha2_js branch.
Exporting state object from main function of Video Alpha.
More stuff from jmclaus/videoalpha2_js branch.
Specs in html5_video.js all pass except ten of them. Cleaned code a bit and moved it out of display_spec.js
One more spec passes
Fixed remaning tests in spec/../html5_video.js test suite. Removed test video files.
Added JavaScript Jasmine tests for main of Video Alpha 2.
adds test for volume control and updates helper file for videoalpha
valera-rozuvan pushed a commit that referenced this pull request Jul 22, 2013
Added missing file.~
Undid a mistake.
Copied Python tests from video_alpha1.
moves TestLogic to __init__.py
reorginizes xmodule logic tests
adds docstrings for poll tests
adds docstring for word cloud and conditional tests
adds docstrings for video alpha tests
adds videoalphafactory for tests, not finished
adds imports
Bug fixing.
fix video/videoalpha tests
Updated lettuce test. Now it is aware of the fact that Video and Video Alpha players have different base CSS classes.
Removed REFACTOR comments.
Turn off autoplay for Video Alpha in Studio.
Carry over fix for bug where in Firefox changing to speed 1.0 has no effect.
Carry over JavaScript Jasmine tests from jmclaus/videoalpha2_js branch.
Exporting state object from main function of Video Alpha.
More stuff from jmclaus/videoalpha2_js branch.
Specs in html5_video.js all pass except ten of them. Cleaned code a bit and moved it out of display_spec.js
One more spec passes
Fixed remaning tests in spec/../html5_video.js test suite. Removed test video files.
Added JavaScript Jasmine tests for main of Video Alpha 2.
adds test for volume control and updates helper file for videoalpha
valera-rozuvan pushed a commit that referenced this pull request Jul 22, 2013
Added missing file.~
Undid a mistake.
Copied Python tests from video_alpha1.
moves TestLogic to __init__.py
reorginizes xmodule logic tests
adds docstrings for poll tests
adds docstring for word cloud and conditional tests
adds docstrings for video alpha tests
adds videoalphafactory for tests, not finished
adds imports
Bug fixing.
fix video/videoalpha tests
Updated lettuce test. Now it is aware of the fact that Video and Video Alpha players have different base CSS classes.
Removed REFACTOR comments.
Turn off autoplay for Video Alpha in Studio.
Carry over fix for bug where in Firefox changing to speed 1.0 has no effect.
Carry over JavaScript Jasmine tests from jmclaus/videoalpha2_js branch.
Exporting state object from main function of Video Alpha.
More stuff from jmclaus/videoalpha2_js branch.
Specs in html5_video.js all pass except ten of them. Cleaned code a bit and moved it out of display_spec.js
One more spec passes
Fixed remaning tests in spec/../html5_video.js test suite. Removed test video files.
Added JavaScript Jasmine tests for main of Video Alpha 2.
adds test for volume control and updates helper file for videoalpha
vetrolamu referenced this pull request in pelikanchik/edx-platform Jul 30, 2013
valera-rozuvan pushed a commit that referenced this pull request Jul 31, 2013
Added missing file.~
Undid a mistake.
Copied Python tests from video_alpha1.
moves TestLogic to __init__.py
reorginizes xmodule logic tests
adds docstrings for poll tests
adds docstring for word cloud and conditional tests
adds docstrings for video alpha tests
adds videoalphafactory for tests, not finished
adds imports
Bug fixing.
fix video/videoalpha tests
Updated lettuce test. Now it is aware of the fact that Video and Video Alpha players have different base CSS classes.
Removed REFACTOR comments.
Turn off autoplay for Video Alpha in Studio.
Carry over fix for bug where in Firefox changing to speed 1.0 has no effect.
Carry over JavaScript Jasmine tests from jmclaus/videoalpha2_js branch.
Exporting state object from main function of Video Alpha.
More stuff from jmclaus/videoalpha2_js branch.
Specs in html5_video.js all pass except ten of them. Cleaned code a bit and moved it out of display_spec.js
One more spec passes
Fixed remaning tests in spec/../html5_video.js test suite. Removed test video files.
Added JavaScript Jasmine tests for main of Video Alpha 2.
adds test for volume control and updates helper file for videoalpha
awaisdar001 added a commit that referenced this pull request Oct 30, 2019
pwnage101 added a commit that referenced this pull request Feb 27, 2020
…n_siteconfiguration_values_2.1

Rename values in SiteConfiguration (2/3) attempt #2
pwnage101 added a commit that referenced this pull request Feb 27, 2020
…_configuration_siteconfiguration_values_2.1

Revert "Rename values in SiteConfiguration (2/3) attempt #2"
pwnage101 added a commit that referenced this pull request Mar 4, 2020
This reverts commit e6f58b6.

This is our third (3rd!) attempt to deploy stage 2 of this column rename.
pwnage101 added a commit that referenced this pull request Mar 5, 2020
…iguration_siteconfiguration_values_2.3

Revert "Revert "Rename values in SiteConfiguration (2/3) attempt #2""  (attempt #3)
awais786 added a commit that referenced this pull request Dec 1, 2020
� This is the 1st commit message:

BOM-2130
Upgrade the django-rest framework.

� This is the commit message #2:

BOM-2130
Upgrade the django-rest framework.
awais786 added a commit that referenced this pull request Mar 18, 2021
# This is the 1st commit message:

BOM-2442
pyupgrade in course-duration

# This is the commit message #2:

Pyupgrade in openedx/features.
tehreem-sadat referenced this pull request in wikimedia/edx-platform Sep 2, 2021
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
* feat: add packages dir to .gitignore

* Investigate exam redirect (openedx#2)

* feat: remove exam redirect

* feat: take control over exam instructions

* refactor: use fedx code structure

* fix: remove debug logging, remove redirect check

Co-authored-by: Vladas Tamoshaitis <[email protected]>

* Add state and reducer for check microfrontend_special_exams waffle flag (openedx#4)

* feat: add state and reducer for check microfrontend_special_exams waffle flag

* fix: rename special exams enabled flag

* fix: rename reducer for setting special exams enabled flag

* refactor: timer feature

* feat(tests): extend tests + fix failing ones, fix quality

* fix: revert removing package lock file

Co-authored-by: Vladas Tamoshaitis <[email protected]>

* fix: naming of waffle flag helpers to reflect relation with mfe

* fix: change naming of the waffle flag

* fix: revert remove package lock file

* feat: switch to @edx npm package

* fix: Remove redundant references from .gitignore

* fix: add is_mfe_special_exams_enabled to courseMetadata.factory.js

* fix: fix tests for 'Sequence' content wrapped in 'SequenceExamWrapper'

Co-authored-by: Sagirov Eugeniy <[email protected]>
Co-authored-by: Vladas Tamoshaitis <[email protected]>
Co-authored-by: Sagirov Evgeniy <[email protected]>
Co-authored-by: Igor Degtiarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants