Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSD] adds annotations for XBLOCK_SELECT_FUNCTION #26164

Merged
merged 1 commit into from
Jan 29, 2021
Merged

[TSD] adds annotations for XBLOCK_SELECT_FUNCTION #26164

merged 1 commit into from
Jan 29, 2021

Conversation

eLRuLL
Copy link
Contributor

@eLRuLL eLRuLL commented Jan 26, 2021

@openedx-webhooks
Copy link

Thanks for the pull request, @eLRuLL! I've created OSPR-5556 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 26, 2021
@eLRuLL eLRuLL force-pushed the raul/tsd-xblock-select_function branch from 97c10fa to 164035a Compare January 26, 2021 00:56
@natabene
Copy link
Contributor

@eLRuLL Thank you! @robrap Please review.

robrap
robrap reviewed Jan 26, 2021
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the annotations. I've got some questions.

lms/envs/common.py Show resolved Hide resolved
lms/envs/common.py Outdated Show resolved Hide resolved
@eLRuLL eLRuLL force-pushed the raul/tsd-xblock-select_function branch 2 times, most recently from 68339c5 to b94a356 Compare January 26, 2021 21:29
@eLRuLL
Copy link
Contributor Author

eLRuLL commented Jan 26, 2021

Thanks for the annotations. I've got some questions.

@robrap this is ready for review

@eLRuLL eLRuLL requested a review from robrap January 26, 2021 21:30
robrap
robrap reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue. Thanks for the updates!

lms/envs/common.py Outdated Show resolved Hide resolved
robrap
robrap approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again. If you squash I can merge when green in the morning.

@eLRuLL
adds annotations for XBLOCK_SELECT_FUNCTION
24f528c 
improves the setting_description for XBLOCK_SELECT_FUNCTION

removes extra setting_description
@eLRuLL eLRuLL force-pushed the raul/tsd-xblock-select_function branch from 5fe9a1a to 24f528c Compare January 29, 2021 12:58
@eLRuLL
Copy link
Contributor Author

eLRuLL commented Jan 29, 2021

Thank you again. If you squash I can merge when green in the morning.

squashed 👍

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@robrap robrap merged commit 22a1ad5 into openedx:master Jan 29, 2021
@openedx-webhooks
Copy link

@eLRuLL 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@bradenmacdonald bradenmacdonald deleted the raul/tsd-xblock-select_function branch January 12, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap approved these changes

Assignees
No one assigned
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eLRuLL @openedx-webhooks @natabene @edx-status-bot @edx-pipeline-bot @robrap