Incidental functionality improvements from Next Gen Modulestore work #269

cpennington · 2013-06-26T02:07:05Z

@dmitchell: Please review content and add reviewers to validate changes.

This builds on top of #268 (net change: edx/edx-platform@dhm/cosmetic-cleanup...dhm/incidental-functionality-improvements)

dmitchell · 2013-06-26T14:25:31Z

@cahrens @chrisndodge @jzoldak Please review (number 2 of 4)

chrisndodge · 2013-06-26T14:58:54Z

Overall comment: It's unfortunate that we see the deltas which are in the 1st PR. Don suggested if we merge the first PR, those deltas will no longer appear in this PR. Is that true?

If so, can we merge the 1st PR so to clean up this 2nd PR. My understanding is that we're breaking up the PR's to make things much more atomic.

cpennington · 2013-06-26T15:34:07Z

Yes, it's true. We definitely want to make things more atomic, but I didn't
want to try and make each PR off of master, since that would have
introduced more conflicts to resolve.

However, you can also look at the pure delta by clicking the link in the PR
to the github compare page.

On Wed, Jun 26, 2013 at 10:59 AM, chrisndodge [email protected]:

Overall comment: It's unfortunate that we see the deltas which are in the
1st PR. Don suggested if we merge the first PR, those deltas will no longer
appear in this PR. Is that true?

If so, can we merge the 1st PR so to clean up this 2nd PR. My
understanding is that we're breaking up the PR's to make things much more
atomic.

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/269#issuecomment-20053383
.

cahrens · 2013-06-26T15:52:29Z

common/lib/xmodule/xmodule/modulestore/xml_exporter.py

+from json.encoder import JSONEncoder
+import datetime
+
+class EdxJSONEncoder(json.JSONEncoder):


Unit test for this class?

chrisndodge · 2013-06-27T13:46:42Z

+1 but we must verify that deploying the config change will work against the previous code deploy, otherwise there will be downtime. My suggestion would be to do the config change on sandbox/stage ahead of code deploy and verify that things work (both draft/direct).

…/ into :/

…ooking up data

During policy export, we want to write any python datetime objects found as iso timestamps, rather than throwing exceptions.

cahrens · 2013-06-30T17:20:45Z

I am ready to give a thumbs-up once there are negative tests for almost_same_datetime and Chris' question about config change is settled.

cpennington · 2013-06-30T19:29:54Z

I have the negative tests. I just need to merge them. We need to do some
fixes to make the code backwards compatible with the prod config.

-Cale
On Jun 30, 2013 1:20 PM, "Christina Roberts" [email protected]
wrote:

I am ready to give a thumbs-up once there are negative tests for
almost_same_datetime and Chris' question about config change is settled.

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/269#issuecomment-20250792
.

DraftModuleStore was originally designed as a mixin, but never used that way, and with the upcoming changes to use the versioned module store, never will be. This changes removes a circular dependency between mongo.py and draft.py.

…ments Incidental functionality improvements from Next Gen Modulestore work

Run all images through compression

…de-complete-count ziafazal/api-fix-users-grade-complete-count: fixed count exceeding total...

Changes for new course split mongo

* Client credentials + grades api (openedx#228) * Client credentials and grades api * Updating the permissions on the fly for request object (openedx#233) * Updating the permissions on the fly for request object * Update views.py

Co-authored-by: Renovate Bot <[email protected]>

cpennington mentioned this pull request Jun 26, 2013

Non-persisted studio templates #270

Merged

cahrens reviewed Jun 26, 2013
View reviewed changes

Don Mitchell added 7 commits June 28, 2013 14:19

Handle edge case when trying to aggregate progress in an empty sequence

26aa085

Make url matching regex flexible to allow for browsers that munged :/…

97c2e9e

…/ into :/

Fix SessionKeyValueStore.has to use the correct indexing value when l…

e9bd1c5

…ooking up data

Retrieve location from self in CustomTagDescriptor

115b214

Make request.POST be only json content when using expect_json

c7046df

Standardize on get_default_time_display

2ef4d82

Add JSON encoder for datetimes to xml export

1c5706f

During policy export, we want to write any python datetime objects found as iso timestamps, rather than throwing exceptions.

Don Mitchell added 8 commits July 1, 2013 12:31

WIP: Use approximate comparison when checking for changes to start dates

3188bb0

Test start_date in course settings

274f1d1

Assert date equality directly, rather than by using a delta of 0

db59aca

Remove extraneous test for already handled edge case

7892fd7

Make DraftModuleStore mongo only

ddfbe59

DraftModuleStore was originally designed as a mixin, but never used that way, and with the upcoming changes to use the versioned module store, never will be. This changes removes a circular dependency between mongo.py and draft.py.

Force locations to be Location objects earlier

a2524c5

Customtags can't be inserted by studio

2fc7d33

Work around XBlock limitations to force persistance of field mutation

ef9c299

cpennington added a commit that referenced this pull request Jul 1, 2013

Merge pull request #269 from edx/dhm/incidental-functionality-improve…

1a7b833

…ments Incidental functionality improvements from Next Gen Modulestore work

cpennington merged commit 1a7b833 into master Jul 1, 2013

cpennington deleted the dhm/incidental-functionality-improvements branch July 1, 2013 20:04

cpennington mentioned this pull request Jul 2, 2013

Pylint errors #321

Merged

chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014

Merge pull request openedx#269 from MITx/kf-multicourse-design

a79afa7

Run all images through compression

Kelketek referenced this pull request in open-craft/edx-platform Oct 21, 2014

Merge pull request #269 from edx-solutions/ziafazal/api-fix-users-gra…

e5632d0

…de-complete-count ziafazal/api-fix-users-grade-complete-count: fixed count exceeding total...

diegomillan referenced this pull request in eduNEXT/edx-platform Sep 14, 2016

Merge pull request #269 from Stanford-Online/caijim/reallysplitting

59af276

Changes for new course split mongo

Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022

fix(deps): update dependency core-js to v3.16.1 (openedx#269)

1fbd9d4

Co-authored-by: Renovate Bot <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incidental functionality improvements from Next Gen Modulestore work #269

Incidental functionality improvements from Next Gen Modulestore work #269

cpennington commented Jun 26, 2013

dmitchell commented Jun 26, 2013

chrisndodge commented Jun 26, 2013

cpennington commented Jun 26, 2013

cahrens Jun 26, 2013

cpennington Jun 26, 2013

chrisndodge commented Jun 27, 2013

cahrens commented Jun 30, 2013

cpennington commented Jun 30, 2013

Incidental functionality improvements from Next Gen Modulestore work #269

Incidental functionality improvements from Next Gen Modulestore work #269

Conversation

cpennington commented Jun 26, 2013

dmitchell commented Jun 26, 2013

chrisndodge commented Jun 26, 2013

cpennington commented Jun 26, 2013

cahrens Jun 26, 2013

Choose a reason for hiding this comment

cpennington Jun 26, 2013

Choose a reason for hiding this comment

chrisndodge commented Jun 27, 2013

cahrens commented Jun 30, 2013

cpennington commented Jun 30, 2013