Make server errors return JSON if requested via AJAX #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 looks like a good approach/pattern. Thanks for taking the initiative! Build is failing, but I don't see any failed tests. Is it due to pep8/pylint limits? |
|
Hey, just going through the list of open PR's. Think we can kick off another build to see if it passes and then merge? |
|
What is the status of this PR? Is it the fix for STUD-260? |
On Linux, coffeescript refuses to compile unless the `catch` keyword has an error variable to bind to. On Mac, it works just fine either way. Go figure.
|
@cahrens Yes, this PR should fix STUD-260. I just need to figure out why it's causing the Jenkins build to fail... |
singingwolfboy
added a commit
that referenced
this pull request
Jul 1, 2013
Make server errors return JSON if requested via AJAX
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Mm more copy
antoviaque
referenced
this pull request
in open-craft/edx-platform
Sep 24, 2014
Fix failing comment client tests.
diegomillan
referenced
this pull request
in eduNEXT/edx-platform
Sep 14, 2016
Graphing Course Forums Data
prabhanshu
pushed a commit
to prabhanshu/edx-platform
that referenced
this pull request
Oct 13, 2018
* Client credentials + grades api (openedx#228) * Client credentials and grades api * Updating the permissions on the fly for request object (openedx#233) * Updating the permissions on the fly for request object * Update views.py
CrewS
pushed a commit
to CrewS/edx-platform-1
that referenced
this pull request
Jan 14, 2019
update png
edx-secure
pushed a commit
that referenced
this pull request
Aug 11, 2021
fix: update lxml parser for celery tasks to be more secure
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
* Commits: chore(deps): update dependency codecov to v3.8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our default error handler is popping up rendered HTML error pages because our error handlers are returning HTML. It would be much saner to return JSON when requested via AJAX, even on errors. This pull request makes that happen.