Pylint errors #321
Merged
Pylint errors #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,7 +106,6 @@ def check_export_roundtrip(self, data_dir, course_dir): | |||
| second_import.modules[course_id][location]) | |||
|
|
|||
| def setUp(self): | |||
| self.maxDiff = None | |||
There was a problem hiding this comment.
We shouldn't remove this line. That attribute tells unittest how long a diff to display in case of failure, and is there because these tests likely have long diffs. Pylint complains, but we can change pylintrc to not do that.
|
Looks good to me. |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…style Fixed jquery ui image problem and added a base style sheet for lms to ov...
e-kolpakov
referenced
this pull request
in open-craft/edx-platform
Dec 9, 2014
…nvalid-data ziafazal/api-time-series-invalid-data: fix negative values in users_not_started
Yasui-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 2, 2015
Yasui-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 2, 2015
…o0917 added staging logo image on cms(openedx#321)
Yasui-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 6, 2015
…o0917 added staging logo image on cms(openedx#321) (cherry picked from commit 8119175)
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
* origin/aliang8/quality: Fix 171 PEP8 errors
CrewS
pushed a commit
to CrewS/edx-platform-1
that referenced
this pull request
Mar 13, 2019
Add baidu bridge
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nedbat @jzoldak: This should drop the number of pep8 and pylint errors (some of which were introduced by #269)