Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix(blockdeviceclaims): fix openebs version type in blockdeviceclaim #1270

Merged
merged 4 commits into from
Jun 8, 2019

Conversation

mittachaitu
Copy link

What this PR does / why we need it:
This PR fixes typo in builder pattern of block device claim from openebs.io/version --> openebs.io/v1alpha1

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

prateekpandey14 and others added 4 commits June 7, 2019 20:43
…chive#1264)

With latest changes, to create StoragePoolClaim we have to
use spc type blockdevice as common type instead of sparse/disk
for creating sparse or disk based cstor pools

```
apiVersion: openebs.io/v1alpha1
kind: StoragePoolClaim
metadata:
  name: sparse-claim-auto
spec:
  name: sparse-claim-auto
  type: blockdevice
  maxPools: 1
  minPools: 1
  poolSpec:
    poolType: striped
    cacheFile: /var/openebs/sparse/sparse-claim-auto.cache
    overProvisioning: false
```

Signed-off-by: prateekpandey14 <[email protected]>
@mittachaitu mittachaitu requested a review from AmitKumarDas June 8, 2019 16:24
@mittachaitu mittachaitu added the pr/upgrade-changes-pending This PR requires upgrade changes to be automated label Jun 8, 2019
Copy link

@AmitKumarDas AmitKumarDas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@AmitKumarDas AmitKumarDas merged commit 15bb30a into openebs-archive:v1.0.x Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/upgrade-changes-pending This PR requires upgrade changes to be automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants