refact(cstor-pool,sparse): Update SPC type to blockdevice #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekpandey14
changed the title
prateekpandey14
changed the title
With latest changes, to create StoragePoolClaim we have to
use spc type blockdevice as common type instead of sparse/disk
for creating sparse or disk based cstor pools
```
apiVersion: openebs.io/v1alpha1
kind: StoragePoolClaim
metadata:
name: sparse-claim-auto
spec:
name: sparse-claim-auto
type: blockdevice
maxPools: 1
minPools: 1
poolSpec:
poolType: striped
cacheFile: /var/openebs/sparse/sparse-claim-auto.cache
overProvisioning: false
```
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
update-sparse-pool
branch
from
e07be28 to
0050152
Compare
AmitKumarDas
added
component: CStorOperator
NDM
type: Documentation
pr/upgrade-changes-pending
mittachaitu
pushed a commit
to mittachaitu/maya
that referenced
this pull request
Jun 7, 2019
…chive#1264) With latest changes, to create StoragePoolClaim we have to use spc type blockdevice as common type instead of sparse/disk for creating sparse or disk based cstor pools ``` apiVersion: openebs.io/v1alpha1 kind: StoragePoolClaim metadata: name: sparse-claim-auto spec: name: sparse-claim-auto type: blockdevice maxPools: 1 minPools: 1 poolSpec: poolType: striped cacheFile: /var/openebs/sparse/sparse-claim-auto.cache overProvisioning: false ``` Signed-off-by: prateekpandey14 <[email protected]>
9 tasks
prateekpandey14
pushed a commit
that referenced
this pull request
Jun 7, 2019
…unclaimed BD in manual mode (#1267) * refact(cstor-pool,sparse): Update SPC type to blockdevice (#1264) With latest changes, to create StoragePoolClaim we have to use spc type blockdevice as common type instead of sparse/disk for creating sparse or disk based cstor pools ``` apiVersion: openebs.io/v1alpha1 kind: StoragePoolClaim metadata: name: sparse-claim-auto spec: name: sparse-claim-auto type: blockdevice maxPools: 1 minPools: 1 poolSpec: poolType: striped cacheFile: /var/openebs/sparse/sparse-claim-auto.cache overProvisioning: false ``` Signed-off-by: prateekpandey14 <[email protected]> * feat(cstor-operator): add a support to create pools on unclaimed BD in manual mode (#1255) Signed-off-by: mittachaitu <[email protected]>
AmitKumarDas
pushed a commit
that referenced
this pull request
Jun 8, 2019
…ckdeviceclaim (#1270) * refact(cstor-pool,sparse): Update SPC type to blockdevice (#1264) With latest changes, to create StoragePoolClaim we have to use spc type blockdevice as common type instead of sparse/disk for creating sparse or disk based cstor pools ``` apiVersion: openebs.io/v1alpha1 kind: StoragePoolClaim metadata: name: sparse-claim-auto spec: name: sparse-claim-auto type: blockdevice maxPools: 1 minPools: 1 poolSpec: poolType: striped cacheFile: /var/openebs/sparse/sparse-claim-auto.cache overProvisioning: false ``` Signed-off-by: prateekpandey14 <[email protected]> * feat(cstor-operator): add a support to create pools on unclaimed BD in manual mode (#1255) Signed-off-by: mittachaitu <[email protected]> * fix(blockdeviceclaims): fix openebs version type in blockdeviceclaim (#1269) Signed-off-by: mittachaitu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With latest cstor pool configuration changes, to create StoragePoolClaim we have to
use spc
type: blockdeviceas common type to create Storagepool based on either disk or sparse.The type specific info i.e.
SparseandDiskhas been move to theBlockDeviceClaimresource.1. New SPC example where
type: blockdevicehas been set for all.2. Old SPC example where we have to set
type: sparseto create a sparse based pool.Refer PR #1255 for more details
Signed-off-by: prateekpandey14 [email protected]
Checklist:
documentationtagbreaking-changestagrequires-upgradetag