fix(blockdeviceclaims): fix openebs version type in blockdeviceclaim #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitKumarDas
reviewed
Jun 8, 2019
Signed-off-by: mittachaitu <[email protected]>
mittachaitu
pushed a commit
to mittachaitu/maya
that referenced
this pull request
Jun 8, 2019
…penebs-archive#1269) Signed-off-by: mittachaitu <[email protected]>
AmitKumarDas
pushed a commit
that referenced
this pull request
Jun 8, 2019
…ckdeviceclaim (#1270) * refact(cstor-pool,sparse): Update SPC type to blockdevice (#1264) With latest changes, to create StoragePoolClaim we have to use spc type blockdevice as common type instead of sparse/disk for creating sparse or disk based cstor pools ``` apiVersion: openebs.io/v1alpha1 kind: StoragePoolClaim metadata: name: sparse-claim-auto spec: name: sparse-claim-auto type: blockdevice maxPools: 1 minPools: 1 poolSpec: poolType: striped cacheFile: /var/openebs/sparse/sparse-claim-auto.cache overProvisioning: false ``` Signed-off-by: prateekpandey14 <[email protected]> * feat(cstor-operator): add a support to create pools on unclaimed BD in manual mode (#1255) Signed-off-by: mittachaitu <[email protected]> * fix(blockdeviceclaims): fix openebs version type in blockdeviceclaim (#1269) Signed-off-by: mittachaitu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu [email protected]
What this PR does / why we need it:
This PR fixes typo in builder pattern of block device claim from openebs.io/version --> openebs.io/v1alpha1
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag