This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fixes history index iteration breaking instead of continuing #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbbaughe
requested review from
mihirsoni,
zengyan-amazon,
jinsoor-amzn and
qreshi
qreshi
approved these changes
Jan 14, 2020
zengyan-amazon
approved these changes
Jan 14, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Jan 16, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Jan 16, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Jan 16, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Jan 16, 2020
dbbaughe
added a commit
that referenced
this pull request
Jan 17, 2020
dbbaughe
added a commit
that referenced
this pull request
Jan 17, 2020
* Adds null check in cluster changed event sweep (#125) * Fixes history index iteration breaking instead of continuing (#134) * Fixes issue where action timeout was using start_time from previous action (#133) * Removes transitive dependencies for notification (#105) * Removes transitive dependencies for notification * Removes resolution strategy for removed transient dependencies and adds excludes for testCompile because of jarHell w/ elasticsearch.test:framework * Remove excludes in test dependencies (#108) * Updates plugin version * Updates usage of LockService to new async API (#107) * Updates job scheduler test resource that contains async lock service
dbbaughe
added a commit
that referenced
this pull request
Jan 17, 2020
* Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm (#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment * Adds null check in cluster changed event sweep (#125) * Fixes history index iteration breaking instead of continuing (#134) * Fixes issue where action timeout was using start_time from previous action (#133) * Bumps plugin version and notification dependency * Updates usage of LockService to new async API (#107) Co-authored-by: Jinsoo <[email protected]>
dbbaughe
added a commit
that referenced
this pull request
Jan 17, 2020
* Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm (#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment * Adds null check in cluster changed event sweep (#125) * Fixes history index iteration breaking instead of continuing (#134) * Fixes issue where action timeout was using start_time from previous action (#133) * Removes transitive dependencies for notification (#105) * Removes transitive dependencies for notification * Removes resolution strategy for removed transient dependencies and adds excludes for testCompile because of jarHell w/ elasticsearch.test:framework * Remove excludes in test dependencies (#108) * Updates plugin version and notification dependency * Updates test resources Co-authored-by: Jinsoo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
If we find the history index we should continue instead of breaking in the loop iteration.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.