This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PolicySeqNo and PolicyPrimaryTerm
jinsoor-amzn
changed the title
qreshi
reviewed
Dec 4, 2019
| updateManagedIndexConfigStartTime(managedIndexConfig) | ||
| waitFor { assertEquals(policyID, getExplainManagedIndexMetaData(firstIndex).policyID) } | ||
|
|
||
| // Need to speed up to second execution where it will trigger the first execution of the action which |
There was a problem hiding this comment.
NP: All of these comments have an extraneous "which" at the end
There was a problem hiding this comment.
I hunted down all the witches. You're welcome.
dbbaughe
previously approved these changes
Dec 4, 2019
dbbaughe
approved these changes
Dec 4, 2019
qreshi
approved these changes
Dec 4, 2019
jinsoor-amzn
added a commit
to jinsoor-amzn/index-management
that referenced
this pull request
Dec 4, 2019
… PolicySeqNo and PolicyPrimaryTerm (opendistro-for-elasticsearch#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment
jinsoor-amzn
added a commit
to jinsoor-amzn/index-management
that referenced
this pull request
Dec 4, 2019
… PolicySeqNo and PolicyPrimaryTerm (opendistro-for-elasticsearch#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment
dabr-grapeup
pushed a commit
to grapeup/index-management
that referenced
this pull request
Dec 5, 2019
… PolicySeqNo and PolicyPrimaryTerm (opendistro-for-elasticsearch#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment
dbbaughe
pushed a commit
to dbbaughe/index-management
that referenced
this pull request
Dec 10, 2019
… PolicySeqNo and PolicyPrimaryTerm (opendistro-for-elasticsearch#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment
dbbaughe
added a commit
that referenced
this pull request
Dec 10, 2019
* Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm (#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment * Bumps plugin version
dbbaughe
pushed a commit
to dbbaughe/index-management
that referenced
this pull request
Jan 16, 2020
… PolicySeqNo and PolicyPrimaryTerm (opendistro-for-elasticsearch#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment
dbbaughe
pushed a commit
to dbbaughe/index-management
that referenced
this pull request
Jan 16, 2020
… PolicySeqNo and PolicyPrimaryTerm (opendistro-for-elasticsearch#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment
dbbaughe
added a commit
that referenced
this pull request
Jan 17, 2020
* Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm (#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment * Adds null check in cluster changed event sweep (#125) * Fixes history index iteration breaking instead of continuing (#134) * Fixes issue where action timeout was using start_time from previous action (#133) * Bumps plugin version and notification dependency * Updates usage of LockService to new async API (#107) Co-authored-by: Jinsoo <[email protected]>
dbbaughe
added a commit
that referenced
this pull request
Jan 17, 2020
* Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm (#121) * Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm * add rollover test case for no condition * remove 'which' in the comment * Adds null check in cluster changed event sweep (#125) * Fixes history index iteration breaking instead of continuing (#134) * Fixes issue where action timeout was using start_time from previous action (#133) * Removes transitive dependencies for notification (#105) * Removes transitive dependencies for notification * Removes resolution strategy for removed transient dependencies and adds excludes for testCompile because of jarHell w/ elasticsearch.test:framework * Remove excludes in test dependencies (#108) * Updates plugin version and notification dependency * Updates test resources Co-authored-by: Jinsoo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#117
Description of changes:
Change the Rollover condition to be separate checks and conditions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.