Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Remove excludes in test dependencies #108

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

dbbaughe
Copy link
Contributor

Issue #, if available:

Description of changes:
Issue with class type mismatch between repackaged jars in notification and dependencies pulled in by elasticsearch client. This shouldn't be needed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@lucaswin-amzn lucaswin-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@qreshi qreshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change

@dbbaughe dbbaughe merged commit 6349454 into opendistro-for-elasticsearch:master Nov 21, 2019
dabr-grapeup pushed a commit to grapeup/index-management that referenced this pull request Dec 5, 2019
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Jan 16, 2020
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Jan 16, 2020
dbbaughe added a commit that referenced this pull request Jan 17, 2020
* Adds null check in cluster changed event sweep (#125)

* Fixes history index iteration breaking instead of continuing (#134)

* Fixes issue where action timeout was using start_time from previous action (#133)

* Removes transitive dependencies for notification (#105)

* Removes transitive dependencies for notification

* Removes resolution strategy for removed transient dependencies and adds excludes for testCompile because of jarHell w/ elasticsearch.test:framework

* Remove excludes in test dependencies (#108)

* Updates plugin version

* Updates usage of LockService to new async API (#107)

* Updates job scheduler test resource that contains async lock service
dbbaughe added a commit that referenced this pull request Jan 17, 2020
* Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm (#121)

* Make rollover condition distinct and change ManagedIndexConfig to use PolicySeqNo and PolicyPrimaryTerm

* add rollover test case for no condition

* remove 'which' in the comment

* Adds null check in cluster changed event sweep (#125)

* Fixes history index iteration breaking instead of continuing (#134)

* Fixes issue where action timeout was using start_time from previous action (#133)

* Removes transitive dependencies for notification (#105)

* Removes transitive dependencies for notification

* Removes resolution strategy for removed transient dependencies and adds excludes for testCompile because of jarHell w/ elasticsearch.test:framework

* Remove excludes in test dependencies (#108)

* Updates plugin version and notification dependency

* Updates test resources

Co-authored-by: Jinsoo <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants