This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
add loading state for AD detail page #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
commented
May 19, 2020
| </h1> | ||
| </EuiTitle> | ||
| </EuiFlexItem> | ||
| {!isEmpty(detector) ? ( |
There was a problem hiding this comment.
Should consider hasError to handle exceptions like not found , timeout etc. If any problem occur, we already have code to pop up toast:
useEffect(() => {
if (hasError) {
toastNotifications.addDanger('Unable to find detector');
props.history.push('/detectors');
}
}, [hasError]);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.