This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix detector detail loading state #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizheliu-amazon
approved these changes
May 19, 2020
ylwu-amzn
reviewed
May 19, 2020
ylwu-amzn
reviewed
May 19, 2020
ylwu-amzn
approved these changes
May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #151
Description of changes:
When loading the detector details page, the intermediate state shows a blank detector name and defaults to the 'Feature required' detector state.
This fixes that by keeping track of when data is being requested and loaded, so an intermediate loading state can be shown. Some logic and code cleanup was also made regarding rendering the detector state at the top of the page.
Before:
After:
This PR also makes a minor change to the detector list loading state, where the requesting of info from the backend and the sorting/filtering in the frontend both display a consistent loading page to the user.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.