Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix loading state of detector detail page #151

Closed
ohltyler opened this issue May 18, 2020 · 0 comments · Fixed by #155
Closed

Fix loading state of detector detail page #151

ohltyler opened this issue May 18, 2020 · 0 comments · Fixed by #155
Assignees
@ohltyler
Labels
enhancement Enhance current feature for better performance, user experience, etc

Comments

@ohltyler
Copy link
Contributor

ohltyler commented May 18, 2020 •
edited
Loading

When loading the detector details page, the intermediate loading state always shows an empty detector name and is in the 'Feature required' state.

While loading:

Screen Shot 2020-05-18 at 1 57 16 PM

After loading:

Screen Shot 2020-05-18 at 1 57 34 PM

This should be changed to display something less confusing, and indicate to the user that the detector details are being loaded.
@ohltyler ohltyler added the enhancement Enhance current feature for better performance, user experience, etc label May 18, 2020
@ohltyler ohltyler self-assigned this May 18, 2020
@ohltyler ohltyler mentioned this issue May 19, 2020
Merged
@ohltyler ohltyler linked a pull request May 19, 2020 that will close this issue
Fix detector detail loading state #155
Merged
@ylwu-amzn ylwu-amzn linked a pull request May 19, 2020 that will close this issue
add loading state for AD detail page #156
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ohltyler ohltyler

Labels
enhancement Enhance current feature for better performance, user experience, etc
Projects
None yet
Milestone
No milestone
1 participant
@ohltyler