Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Feature/update-sdk to master #214

Merged
merged 8 commits into from
Mar 29, 2023
Merged

Conversation

VaishnaviHire
Copy link
Member

Closes #176 , #208, #209, #189

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

VaishnaviHire and others added 8 commits March 29, 2023 11:30
* Initialize operator-sdk 1.23

* Add apis from kfctl

* Add KfDef controller

* Add 'pkg' folder

* Add Secret Generator controller

* Update go modules and depricated methods

* Remove b2ndcontroller, update watch functions

* Update 'Apply()' to initalize ApplyOptions

* Update manifests config

* Update Dockerfile, Makefile & README

Update dockerfile

* Add Dashboard CRDs

* Add OLM Bundle
* Allow resource updates using custom built-in plugin

* Add tests to verify configurable resources
@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from vaishnavihire. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2023

@VaishnaviHire: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests 54127cb link true /test unit-tests
ci/prow/operator-e2e 54127cb link true /test operator-e2e
ci/prow/ci-index 54127cb link true /test ci-index
ci/prow/images 54127cb link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VaishnaviHire
Copy link
Member Author

The CI failures are expected. This PR in release repo aims to update CI test config to support new operator and its e2e tests.

@VaishnaviHire VaishnaviHire merged commit acb774f into master Mar 29, 2023
VaishnaviHire added a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Apr 24, 2024
Restore trustyAI manifest references in 2.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Operator SDK and Go version
2 participants