Update operator-sdk and Go version #184

VaishnaviHire · 2022-10-25T14:44:31Z

Fixes #176

Description

Update Operator to run with latest SDK and Go version 1.17
Remove support for Kfdef v1alpha1, v1beta1

How Has This Been Tested?

Openshift cluster 4.11
Deployment instructions:
- Deploy using OLM
- Deploy locally

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

shalberd · 2022-11-04T15:56:45Z

so neat, thank you for making that change, @VaishnaviHire . Now, with config/manager/manager.yaml present and OCP 4.10, it becomes much easier to make an operator bundle supporting a set of relatedImages, and without having to manually find out the sha256 digests. See https://docs.openshift.com/container-platform/4.10/operators/operator_sdk/osdk-generating-csvs.html#olm-enabling-operator-for-restricted-network_osdk-generating-csvs @Jooho

openshift-ci · 2022-12-23T12:27:26Z

@VaishnaviHire: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/operator-e2e	`619b3cf`	link	true	`/test operator-e2e`
ci/prow/unit-tests	`619b3cf`	link	true	`/test unit-tests`
ci/prow/ci-index	`619b3cf`	link	true	`/test ci-index`
ci/prow/images	`619b3cf`	link	true	`/test images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

VaishnaviHire · 2022-12-23T12:29:38Z

Note: This PR is ready for reviews

anishasthana · 2022-12-25T06:12:55Z

Dockerfile

-COPY go.mod .
-COPY go.sum .
+# Build the manager binary
+FROM golang:1.18 as builder


Can we use one of the one of the ubi8/golang tool images?
I'm seeing a bunch at

❯ skopeo list-tags docker://registry.access.redhat.com/ubi8/go-toolset | grep 1.18 "1.18", "1.18.4", "1.14.12-17.1618436992-source", "1.18.4-8.1669838000-source", "1.14.12-17.1618436992", "1.18.4-8-source", "1.18.4-8.1669838000", "1.18.4-8",

@VaishnaviHire Can you make the version a docker ARG? Do we need to add the z-stream (1.18.9) to minimize any rebuilds from breaking due to a go version update.

Could you actually use registry.redhat.io/ubi8/go-toolset instead?

Updated the Dockerfile with registry.redhat.io/ubi8/go-toolset image with Go version as a docker ARG

@VaishnaviHire We will have to use registry.access.redhat.com/ubi8/go-toolset for unauthenticated pulls.

VaishnaviHire · 2023-01-04T15:07:47Z

Note: Updated the base branch to feature/update-sdk

LaVLaS · 2023-01-05T15:42:27Z

Dockerfile

-COPY go.mod .
-COPY go.sum .
+# Build the manager binary
+FROM golang:1.18 as builder


@VaishnaviHire Can you make the version a docker ARG? Do we need to add the z-stream (1.18.9) to minimize any rebuilds from breaking due to a go version update.

README.md

VaishnaviHire · 2023-01-10T20:37:41Z

Updated the PR with instructions to deploy Operator using OLM

Dockerfile

LaVLaS · 2023-01-11T03:40:26Z

Makefile

+
+.PHONY: docker-build
+docker-build: manifests generate fmt vet ## Build docker image with the manager.
+	docker build -t ${IMG} .


I can do this in a follow-up PR but we should move use an IMG_BUILDER variable to allow someone to choose podman or docker

We should also default to podman.

@VaishnaviHire I can make this change in a follow-up PR if you want

Dockerfile

README.md

Update dockerfile

LaVLaS

/lgtm

Build and deploy worked perfectly for me without any issues. I created a new kfdef and the operator deployed the pods without any noticeable issues

openshift-ci · 2023-01-17T14:09:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [LaVLaS]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Initialize operator-sdk 1.23 * Add apis from kfctl * Add KfDef controller * Add 'pkg' folder * Add Secret Generator controller * Update go modules and depricated methods * Remove b2ndcontroller, update watch functions * Update 'Apply()' to initalize ApplyOptions * Update manifests config * Update Dockerfile, Makefile & README Update dockerfile * Add Dashboard CRDs * Add OLM Bundle

Signed-off-by: Wen Zhou <[email protected]>

openshift-ci bot added the do-not-merge/work-in-progress label Oct 25, 2022

openshift-merge-robot added the needs-rebase label Oct 25, 2022

openshift-ci bot requested review from anishasthana and LaVLaS October 25, 2022 14:44

shalberd mentioned this pull request Nov 4, 2022

[WIP]: support operator in restricted respectively airgapped network environments #183

Closed

3 tasks

VaishnaviHire force-pushed the update_sdk branch from 4dfb521 to aad0a9b Compare November 8, 2022 17:17

VaishnaviHire force-pushed the update_sdk branch 2 times, most recently from caf42ca to 17b27da Compare December 22, 2022 14:46

VaishnaviHire added 5 commits December 23, 2022 13:23

Initialize operator-sdk 1.23

b4ead5f

Add apis from kfctl

b8a3fd4

Add KfDef controller

11ffbbc

Add 'pkg' folder

9870e2f

Add Secret Generator controller

5236042

VaishnaviHire force-pushed the update_sdk branch from 17b27da to 619b3cf Compare December 23, 2022 12:21

openshift-merge-robot removed the needs-rebase label Dec 23, 2022

VaishnaviHire changed the title ~~[WIP] Update operator-sdk and Go version~~ Update operator-sdk and Go version Dec 23, 2022

openshift-ci bot removed the do-not-merge/work-in-progress label Dec 23, 2022

anishasthana reviewed Dec 25, 2022

View reviewed changes

VaishnaviHire changed the base branch from master to feature/update-sdk January 4, 2023 15:05

LaVLaS reviewed Jan 6, 2023

View reviewed changes

VaishnaviHire added 2 commits January 9, 2023 15:38

Update go modules and depricated methods

7dcdf34

Remove b2ndcontroller, update watch functions

9bcc0b6

VaishnaviHire force-pushed the update_sdk branch from 619b3cf to 5f6a531 Compare January 9, 2023 20:39

VaishnaviHire added 2 commits January 10, 2023 10:06

Update 'Apply()' to initalize ApplyOptions

1efe81b

Update manifests config

b3bc126

VaishnaviHire force-pushed the update_sdk branch from 5f6a531 to 5a688ef Compare January 10, 2023 15:07

VaishnaviHire force-pushed the update_sdk branch from 5a688ef to bc79aab Compare January 10, 2023 20:02

LaVLaS reviewed Jan 11, 2023

View reviewed changes

Dockerfile Show resolved Hide resolved

LaVLaS reviewed Jan 11, 2023

View reviewed changes

Dockerfile Show resolved Hide resolved

LaVLaS reviewed Jan 12, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

VaishnaviHire added 3 commits January 16, 2023 17:14

Update Dockerfile, Makefile & README

00d5a07

Update dockerfile

Add Dashboard CRDs

40215ef

Add OLM Bundle

c698e51

VaishnaviHire force-pushed the update_sdk branch from ea8745a to c698e51 Compare January 16, 2023 22:16

LaVLaS approved these changes Jan 17, 2023

View reviewed changes

openshift-ci bot assigned LaVLaS Jan 17, 2023

openshift-ci bot added the lgtm label Jan 17, 2023

openshift-ci bot added the approved label Jan 17, 2023

openshift-merge-robot merged commit 30f6503 into opendatahub-io:feature/update-sdk Jan 17, 2023

VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Feb 9, 2024

[cherry-pick]: upstream change for var name (opendatahub-io#184)

cca25ec

Signed-off-by: Wen Zhou <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update operator-sdk and Go version #184

Update operator-sdk and Go version #184

VaishnaviHire commented Oct 25, 2022 •

edited

Loading

shalberd commented Nov 4, 2022 •

edited

Loading

openshift-ci bot commented Dec 23, 2022

VaishnaviHire commented Dec 23, 2022

anishasthana Dec 25, 2022

LaVLaS Jan 5, 2023

anishasthana Jan 7, 2023

VaishnaviHire Jan 10, 2023 •

edited

Loading

LaVLaS Jan 10, 2023

VaishnaviHire commented Jan 4, 2023

LaVLaS Jan 5, 2023

VaishnaviHire commented Jan 10, 2023

LaVLaS Jan 11, 2023

anishasthana Jan 11, 2023

LaVLaS Jan 17, 2023

LaVLaS left a comment

openshift-ci bot commented Jan 17, 2023

Update operator-sdk and Go version #184

Update operator-sdk and Go version #184

Conversation

VaishnaviHire commented Oct 25, 2022 • edited Loading

Description

How Has This Been Tested?

Merge criteria:

shalberd commented Nov 4, 2022 • edited Loading

openshift-ci bot commented Dec 23, 2022

VaishnaviHire commented Dec 23, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VaishnaviHire Jan 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VaishnaviHire commented Jan 4, 2023

Choose a reason for hiding this comment

VaishnaviHire commented Jan 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LaVLaS left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 17, 2023

VaishnaviHire commented Oct 25, 2022 •

edited

Loading

shalberd commented Nov 4, 2022 •

edited

Loading

VaishnaviHire Jan 10, 2023 •

edited

Loading