Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ownerreferrences to manifest resources #211

Conversation

VaishnaviHire
Copy link
Member

Fixes #209

Description

Every resource added by the operator will have following ownerrefferences

  ownerReferences:
    - apiVersion: kfdef.apps.kubeflow.org/v1
      kind: KfDef
      name: odh-core
      uid: <uid>
      controller: true
      blockOwnerDeletion: true

How Has This Been Tested?

  1. Deploy operator using make deploy
  2. Create odh-core KfDef
  3. Delete KfDef

Note : resources like Grafana and prometheus will not be deleted, since they are managed by respective operators

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@VaishnaviHire VaishnaviHire linked an issue Mar 20, 2023 that may be closed by this pull request
@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 27, 2023

While this PR have any affect on anyone using the kfctl cli with a kfdef?

@VaishnaviHire VaishnaviHire force-pushed the add_ownerref branch 2 times, most recently from 681657b to a93a6f0 Compare March 27, 2023 21:19
@VaishnaviHire
Copy link
Member Author

While this PR have any affect on anyone using the kfctl cli with a kfdef?

I had removed the cmd directory where kfctl cli is defined, from the operator, since its not being developed(is depricated). The idea was kfctl cli can be installed from upstream.

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[update-sdk] Add OwnerReferences to KfDef CR
3 participants